Replace _ with - in Symbol attribute values

[joeldrapper]

This provides better consistency with Symbol keys and makes it easier to work with standard multi-word HTML attribute values, such as contenteditable: :plaintext_only.

[willcosgrove]

Looks great! I don't think I've ever run into this, but I think I would have expected it to work the way that this PR changes it to work. 🎉

[joelmoss]

Am I missing something, but what happened to the process_attributes hook?

[willcosgrove]

@joelmoss it was renamed: #653 (comment)

[joeldrapper]

The process_attributes hook was removed. You can achieve the same by patching __attributes__ but this is a private API and may change in the future.

[joelmoss]

I missed that, but when and why was it removed? I rely on that and don't like the idea of monkey patching (__attributes__) private API :(

[joeldrapper]

FWIW, it’s very unlikely we’ll rename __attributes__ in the future, and it’s very likely to continue to be sent a single hash argument, which you can format before passing up to super.

[joelmoss]

Can we at least make __attributes__ public then please?

[joeldrapper]

Let’s open an issue for that. There are so many caveats to patching that method, I’m not sure if it’s something we want to encourage.

[joelmoss]

@joelmoss it was renamed: #653 (comment)

I even commented on it! 🤦‍♂️