Typo in method_exists getId HalLinks.php #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type in method getid -> getId
This change allows registering a single HalResource without an identifier. See for more details this issue: #109
Fix typos in $identifierName ($identiferName-> $identifierName)
Changed if clause to explicitly check for $id not being false. Previously when $id is set to int 0 the function results in returning false which is wrong. It should return 0.
Changed if clause to explicitly check for $id not being false. Previously when $id is set to int 0 the getIdentifier function results in returning false which is wrong. It should return the integer 0.
weierophinney
added a commit
that referenced
this pull request
May 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo in method getid -> getId