-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve some warnings when MSVC warning level is 4 #240
Open
Demonese
wants to merge
1
commit into
phoboslab:master
Choose a base branch
from
Demonese:less-warning
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demonese
commented
Aug 21, 2022
Test build system: cmake_minimum_required(VERSION 3.24)
project(qoi)
add_library(libqoi)
if(MSVC)
target_compile_options(libqoi PRIVATE
"/utf-8"
"/W4"
)
else()
target_compile_options(libqoi PRIVATE
"-Wall"
"-Wextra"
"-Wpedantic"
"-Werror"
)
endif()
if(WIN32)
target_compile_definitions(libqoi PRIVATE
_CRT_SECURE_NO_WARNINGS
)
endif()
set_target_properties(libqoi PROPERTIES
C_STANDARD 17
C_STANDARD_REQUIRED ON
)
target_compile_definitions(libqoi PRIVATE
QOI_IMPLEMENTATION
)
target_include_directories(libqoi PUBLIC
.
)
target_sources(libqoi PRIVATE
qoi.h
qoi.c
) qoi.c #ifndef QOI_IMPLEMENTATION
#define QOI_IMPLEMENTATION
#endif
#include "qoi.h" |
vtorri
reviewed
Aug 14, 2023
run = 0; | ||
} | ||
} | ||
else { | ||
int index_pos; | ||
|
||
if (run > 0) { | ||
bytes[p++] = QOI_OP_RUN | (run - 1); | ||
bytes[p++] = QOI_OP_RUN | (unsigned char)(run - 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not declaring run
as an unsigned char
?
vtorri
reviewed
Aug 14, 2023
run = 0; | ||
} | ||
|
||
index_pos = QOI_COLOR_HASH(px) % 64; | ||
|
||
if (index[index_pos].v == px.v) { | ||
bytes[p++] = QOI_OP_INDEX | index_pos; | ||
bytes[p++] = QOI_OP_INDEX | (unsigned char)index_pos; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as run
above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.