Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JSON library CMake + minor update to coupled BTE docs #236

Merged
merged 4 commits into from
Mar 9, 2025
Merged

Update JSON library CMake + minor update to coupled BTE docs #236

merged 4 commits into from
Mar 9, 2025

Conversation

jcoulter12
Copy link
Member

Two small changes are in this PR:

  • It seems nlohmann::json has updated the way CMake integration works, and the lib/CMakeLists.txt file needs to be updated or the code cannot be built.
  • Additionally, I update a few typos and links in the coupled BTE docs.

@jcoulter12 jcoulter12 added bug Something isn't working documentation Improvements or additions to documentation labels Mar 9, 2025
@jcoulter12 jcoulter12 requested a review from BogdanRajkov March 9, 2025 00:16
@jcoulter12 jcoulter12 merged commit 90ba581 into develop Mar 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BogdanRajkov BogdanRajkov Awaiting requested review from BogdanRajkov

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcoulter12