[RTLD] Add support for PIC and being build as shared library #334

badochov · 2024-01-30T14:57:52Z

Description

Motivation and Context

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

Already covered by automatic testing.
New test added: (add PR link here).
Tested by hand on: (list targets here).

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing linter checks and tests passed.
My changes generate no new compilation warnings for any of the targets.

Special treatment

This PR needs additional PRs to work (list the PRs, preferably in merge-order).
I will merge this PR by myself when appropriate.

badochov · 2024-01-30T14:58:50Z

FIrst 3 commits are from different PRs

github-actions · 2024-01-31T15:36:52Z

Unit Test Results

6 780 tests - 920 6 154 ✅ - 831 31m 19s ⏱️ - 8m 9s
380 suites - 56 626 💤 - 89
1 files ± 0 0 ❌ ± 0

Results for commit 77c8fec. ± Comparison against base commit 3375557.

This pull request removes 920 tests.

flash ‑ armv7a9-zynq7000-zedboard:flash
phoenix-rtos-tests/cpp/hello-cpp ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/cpp/hello-cpp
phoenix-rtos-tests/initfini/main ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/initfini/main
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_in
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_in_big
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_inout_big
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_out
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.data_out_big
phoenix-rtos-tests/ioctl/unit ‑ armv7a9-zynq7000-zedboard:phoenix-rtos-tests/ioctl/unit.ioctl.in_val
…

♻️ This comment has been updated with latest results.

github-actions · 2024-08-16T12:37:24Z

include/sys/threads.h

+__attribute__((noreturn))
+extern void endthreadsvc(void);


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

__attribute__((noreturn))

extern void endthreadsvc(void);

__attribute__((noreturn)) extern void endthreadsvc(void);

github-actions · 2024-08-16T12:37:25Z

sys/threads.c

+
+/* Provide stub definition of tls managing functions for statically linked programs. */
+
+static void _libphoenix_stub(void){


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

static void _libphoenix_stub(void){

static void _libphoenix_stub(void)

{

github-actions · 2024-08-16T12:37:25Z

sys/threads.c

+extern void  __attribute__((weak, alias("_libphoenix_stub"))) _rtld_tls_free_curr(void);
+extern void  __attribute__((weak, alias("_libphoenix_stub"))) _rtld_tls_allocate_curr(void);


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

extern void __attribute__((weak, alias("_libphoenix_stub"))) _rtld_tls_free_curr(void);

extern void __attribute__((weak, alias("_libphoenix_stub"))) _rtld_tls_allocate_curr(void);

extern void __attribute__((weak, alias("_libphoenix_stub"))) _rtld_tls_free_curr(void);

extern void __attribute__((weak, alias("_libphoenix_stub"))) _rtld_tls_allocate_curr(void);

github-actions · 2024-08-16T12:37:25Z

sys/threads.c

+
+
+/* FIXME: Hack to provide tls support in dynamically loaded binaries. */
+void beginthreadex_wrapper(void* arg) {


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

void beginthreadex_wrapper(void* arg) {

void beginthreadex_wrapper(void *arg)

{

github-actions · 2024-08-16T12:37:25Z

sys/threads.c

+	start(startArg);
+}
+
+int beginthreadex(void (*start)(void *), unsigned int priority, void *stack, unsigned int stacksz, void *arg, handle_t *id) {


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

int beginthreadex(void (*start)(void *), unsigned int priority, void *stack, unsigned int stacksz, void *arg, handle_t *id) {

int beginthreadex(void (*start)(void *), unsigned int priority, void *stack, unsigned int stacksz, void *arg, handle_t *id)

{

github-actions · 2024-08-16T12:37:25Z

sys/threads.c

+__attribute__((noreturn))
+void endthread(void) {


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

__attribute__((noreturn))

void endthread(void) {

__attribute__((noreturn)) void endthread(void)

{

github-actions · 2024-08-16T15:13:58Z

include/dlfcn.h

+#define RTLD_LAZY	1
+#define RTLD_NOW	2
+#define RTLD_GLOBAL	0x100
+#define RTLD_LOCAL	0x200


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

#define RTLD_LAZY 1

#define RTLD_NOW 2

#define RTLD_GLOBAL 0x100

#define RTLD_LOCAL 0x200

#define RTLD_LAZY 1

#define RTLD_NOW 2

#define RTLD_GLOBAL 0x100

#define RTLD_LOCAL 0x200

github-actions · 2024-08-16T15:13:59Z

include/dlfcn.h

+int    dladdr(const void *restrict, Dl_info_t *restrict);
+int    dlclose(void *);
+char  *dlerror(void);
+void  *dlopen(const char *, int);
+void  *dlsym(void *restrict, const char *restrict);


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

int dladdr(const void *restrict, Dl_info_t *restrict);

int dlclose(void *);

char *dlerror(void);

void *dlopen(const char *, int);

void *dlsym(void *restrict, const char *restrict);

int dladdr(const void *restrict, Dl_info_t *restrict);

int dlclose(void *);

char *dlerror(void);

void *dlopen(const char *, int);

void *dlsym(void *restrict, const char *restrict);

github-actions · 2024-08-21T11:22:47Z

rtld/stubs.c

+
+
+extern void *__tls_get_addr(void *) __attribute__((weak, alias("__libphoenix__tls_get_addr")));
+extern void *___tls_get_addr(void *) __attribute__((weak, alias("__libphoenix___tls_get_addr"))) __attribute__((__regparm__(1))) ;


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

extern void *___tls_get_addr(void *) __attribute__((weak, alias("__libphoenix___tls_get_addr"))) __attribute__((__regparm__(1))) ;

extern void *___tls_get_addr(void *) __attribute__((weak, alias("__libphoenix___tls_get_addr"))) __attribute__((__regparm__(1)));

github-actions · 2024-08-27T16:02:36Z

misc/init.c

+static int _libc_initialized;
+
+
+/* _libc_init is called twice once explicitely in crt0 and once during constructor handling.


[codespell] _{reported by reviewdog 🐶}
explicitely ==> explicitly

github-actions · 2024-08-27T16:02:36Z

misc/init.c

+
+
+/* _libc_init is called twice once explicitely in crt0 and once during constructor handling.
+ * If libc is linked statically first it is called explicitely and then during constructor handling.


[codespell] _{reported by reviewdog 🐶}
explicitely ==> explicitly

github-actions · 2024-08-29T16:14:18Z

arch/arm/v7a/tls.S

+.text
+
+.thumb_func
+/* Declared as weak to be overriden by dynamic linker */


[codespell] _{reported by reviewdog 🐶}
overriden ==> overridden

github-actions · 2024-08-29T16:14:18Z

arch/riscv64/tls.S

+ *
+ * void *__tls_get_addr(TLS_index *ti) */
+
+/* Declared as weak to be overriden by dynamic linker */


[codespell] _{reported by reviewdog 🐶}
overriden ==> overridden

github-actions · 2024-09-02T16:43:16Z

rtld/stubs.c

+}
+
+
+__attribute__((weak)) void *__tls_get_addr(void *d) {


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

__attribute__((weak)) void *__tls_get_addr(void *d) {

__attribute__((weak)) void *__tls_get_addr(void *d)

{

github-actions · 2024-09-02T16:43:16Z

rtld/stubs.c

+}
+
+
+__attribute__((weak)) void *___tls_get_addr(void *d) {


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

__attribute__((weak)) void *___tls_get_addr(void *d) {

__attribute__((weak)) void *___tls_get_addr(void *d)

{

github-actions · 2024-09-02T17:01:43Z

rtld/stubs.c

+
+
+/* As dynamic linker is not added as a NEEDED dependency in libphoenix, stub implementation are required.
+ * They are overriden by dynamic linkers functions in runtime.  */


[codespell] _{reported by reviewdog 🐶}
overriden ==> overridden

github-actions · 2024-09-02T17:01:43Z

rtld/stubs.c

+
+
+/* Stub __tls_get_addr implementations.
+ * They can be overriden on platforms requiring __tls_get_addr in PIC compiled platforms(eg. RISC-V, ARM).


[codespell] _{reported by reviewdog 🐶}
overriden ==> overridden

github-actions · 2024-09-06T10:38:12Z

rtld/stubs.c

+}
+
+
+__attribute__((weak)) void __rtld_atfork(int pre) {


[clang-format-pr] _{reported by reviewdog 🐶}
suggested fix

Suggested change

__attribute__((weak)) void __rtld_atfork(int pre) {

__attribute__((weak)) void __rtld_atfork(int pre)

{

JIRA: RTOS-900

JIRA: RTOS-664

In PIE on ia32 function calls should be made using GOT. JIRA: RTOS-664

JIRA: RTOS-664

This allows constructor handling mechanism in dynamic linker. JIRA: RTOS-664

JIRA: RTOS-664

badochov requested a review from agkaminski January 30, 2024 14:57

badochov force-pushed the badochov/dynamic-linker branch from 9687533 to 37487af Compare January 30, 2024 15:13

badochov mentioned this pull request Jan 30, 2024

[RTLD] Dynamic linker phoenix-rtos/phoenix-rtos-project#990

Draft

13 tasks

badochov force-pushed the badochov/dynamic-linker branch from 37487af to 3da17c2 Compare January 31, 2024 15:24

badochov force-pushed the badochov/dynamic-linker branch 3 times, most recently from c2c4a95 to cfc9a6e Compare February 2, 2024 13:23

badochov force-pushed the badochov/dynamic-linker branch from cfc9a6e to 77c8fec Compare August 5, 2024 17:06

badochov force-pushed the badochov/dynamic-linker branch from 77c8fec to ddc8fe7 Compare August 16, 2024 12:36

github-actions bot reviewed Aug 16, 2024

View reviewed changes

badochov force-pushed the badochov/dynamic-linker branch from ddc8fe7 to 9fe5f55 Compare August 16, 2024 12:56

github-actions bot reviewed Aug 16, 2024

View reviewed changes

badochov force-pushed the badochov/dynamic-linker branch from 2caa8d8 to b72127e Compare August 21, 2024 11:22

github-actions bot reviewed Aug 21, 2024

View reviewed changes

badochov force-pushed the badochov/dynamic-linker branch 3 times, most recently from ab44ee8 to fd5b08c Compare August 27, 2024 16:02

github-actions bot reviewed Aug 27, 2024

View reviewed changes

badochov force-pushed the badochov/dynamic-linker branch 2 times, most recently from 3243e14 to 9547eeb Compare August 29, 2024 16:13

github-actions bot reviewed Aug 29, 2024

View reviewed changes

badochov force-pushed the badochov/dynamic-linker branch from 9547eeb to bee4ca6 Compare September 2, 2024 16:43

github-actions bot reviewed Sep 2, 2024

View reviewed changes

badochov force-pushed the badochov/dynamic-linker branch from bee4ca6 to cae7c5e Compare September 2, 2024 17:01

github-actions bot reviewed Sep 2, 2024

View reviewed changes

badochov force-pushed the badochov/dynamic-linker branch 3 times, most recently from 1fbfbc1 to 531abff Compare September 5, 2024 14:21

badochov force-pushed the badochov/dynamic-linker branch 2 times, most recently from 4e2bbe9 to 0bf6d7d Compare September 6, 2024 10:37

github-actions bot reviewed Sep 6, 2024

View reviewed changes

badochov force-pushed the badochov/dynamic-linker branch 2 times, most recently from 6f6f34b to ab58b63 Compare September 12, 2024 10:42

badochov force-pushed the badochov/dynamic-linker branch 4 times, most recently from d761924 to 0ba38c3 Compare September 18, 2024 07:35

badochov force-pushed the badochov/dynamic-linker branch 5 times, most recently from a561b47 to 47a6b37 Compare October 6, 2024 16:31

badochov force-pushed the badochov/dynamic-linker branch 2 times, most recently from 90eeca8 to 046a16f Compare October 25, 2024 14:32

badochov and others added 12 commits December 5, 2024 13:26

exit: change _atexit_call into __cxa_finalize

3bda7cb

JIRA: RTOS-900

libphoenix: Add option to compile as PIC

b307fbb

JIRA: RTOS-664

ia32: support PIE in asm

a9f2f0c

In PIE on ia32 function calls should be made using GOT. JIRA: RTOS-664

Makefile: generate shared library

1c1695a

JIRA: RTOS-664

dlfcn: create header and stub definitions

e5adb2d

JIRA: RTOS-664

tls: add dynamic linker TLS support

69be3d5

JIRA: RTOS-664

ld.elf_so: add support for __cxa_thread_atexit_impl

cfbf024

JIRA: RTOS-664

init: declare _libc_init as constructor

d4c7e9a

This allows constructor handling mechanism in dynamic linker. JIRA: RTOS-664

shared.mk: install toolchain provided dynamic libraries

6b99f65

JIRA: RTOS-664

shared.mk: strip shared libs in fs

8f7765b

JIRA: RTOS-664

arch/riscv64: respect PIC in asm

5d5413e

JIRA: RTOS-664

sparc: make asm PIC friendly

5a9ff9b

JIRA: RTOS-664

badochov force-pushed the badochov/dynamic-linker branch from 046a16f to 5a9ff9b Compare December 5, 2024 12:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RTLD] Add support for PIC and being build as shared library #334

[RTLD] Add support for PIC and being build as shared library #334

badochov commented Jan 30, 2024

badochov commented Jan 30, 2024

github-actions bot commented Jan 31, 2024 •

edited

Loading

github-actions bot Aug 16, 2024

github-actions bot Aug 16, 2024

github-actions bot Aug 16, 2024

github-actions bot Aug 16, 2024

github-actions bot Aug 16, 2024

github-actions bot Aug 16, 2024

github-actions bot Aug 16, 2024

github-actions bot Aug 16, 2024

github-actions bot Aug 21, 2024

github-actions bot Aug 27, 2024

github-actions bot Aug 27, 2024

github-actions bot Aug 29, 2024

github-actions bot Aug 29, 2024

github-actions bot Sep 2, 2024

github-actions bot Sep 2, 2024

github-actions bot Sep 2, 2024

github-actions bot Sep 2, 2024

github-actions bot Sep 6, 2024

	__attribute__((noreturn))
	extern void endthreadsvc(void);
	__attribute__((noreturn)) extern void endthreadsvc(void);


		/* Provide stub definition of tls managing functions for statically linked programs. */

		static void _libphoenix_stub(void){

	static void _libphoenix_stub(void){
	static void _libphoenix_stub(void)
	{

		extern void __attribute__((weak, alias("_libphoenix_stub"))) _rtld_tls_free_curr(void);
		extern void __attribute__((weak, alias("_libphoenix_stub"))) _rtld_tls_allocate_curr(void);



		/* FIXME: Hack to provide tls support in dynamically loaded binaries. */
		void beginthreadex_wrapper(void* arg) {

	void beginthreadex_wrapper(void* arg) {
	void beginthreadex_wrapper(void *arg)
	{

	int beginthreadex(void (start)(void ), unsigned int priority, void stack, unsigned int stacksz, void arg, handle_t *id) {
	int beginthreadex(void (start)(void ), unsigned int priority, void stack, unsigned int stacksz, void arg, handle_t *id)
	{



		extern void __tls_get_addr(void ) __attribute__((weak, alias("__libphoenix__tls_get_addr")));
		extern void ___tls_get_addr(void ) __attribute__((weak, alias("__libphoenix___tls_get_addr"))) __attribute__((__regparm__(1))) ;

		static int _libc_initialized;


		/* _libc_init is called twice once explicitely in crt0 and once during constructor handling.



		/* _libc_init is called twice once explicitely in crt0 and once during constructor handling.
		* If libc is linked statically first it is called explicitely and then during constructor handling.

	__attribute__((weak)) void __tls_get_addr(void d) {
	__attribute__((weak)) void __tls_get_addr(void d)
	{

	__attribute__((weak)) void ___tls_get_addr(void d) {
	__attribute__((weak)) void ___tls_get_addr(void d)
	{



		/* As dynamic linker is not added as a NEEDED dependency in libphoenix, stub implementation are required.
		* They are overriden by dynamic linkers functions in runtime. */



		/* Stub __tls_get_addr implementations.
		* They can be overriden on platforms requiring __tls_get_addr in PIC compiled platforms(eg. RISC-V, ARM).

	__attribute__((weak)) void __rtld_atfork(int pre) {
	__attribute__((weak)) void __rtld_atfork(int pre)
	{

[RTLD] Add support for PIC and being build as shared library #334

Are you sure you want to change the base?

[RTLD] Add support for PIC and being build as shared library #334

Conversation

badochov commented Jan 30, 2024

Description

Motivation and Context

Types of changes

How Has This Been Tested?

Checklist:

Special treatment

badochov commented Jan 30, 2024

github-actions bot commented Jan 31, 2024 • edited Loading

Unit Test Results

github-actions bot Aug 16, 2024

Choose a reason for hiding this comment

github-actions bot Aug 16, 2024

Choose a reason for hiding this comment

github-actions bot Aug 16, 2024

Choose a reason for hiding this comment

github-actions bot Aug 16, 2024

Choose a reason for hiding this comment

github-actions bot Aug 16, 2024

Choose a reason for hiding this comment

github-actions bot Aug 16, 2024

Choose a reason for hiding this comment

github-actions bot Aug 16, 2024

Choose a reason for hiding this comment

github-actions bot Aug 16, 2024

Choose a reason for hiding this comment

github-actions bot Aug 21, 2024

Choose a reason for hiding this comment

github-actions bot Aug 27, 2024

Choose a reason for hiding this comment

github-actions bot Aug 27, 2024

Choose a reason for hiding this comment

github-actions bot Aug 29, 2024

Choose a reason for hiding this comment

github-actions bot Aug 29, 2024

Choose a reason for hiding this comment

github-actions bot Sep 2, 2024

Choose a reason for hiding this comment

github-actions bot Sep 2, 2024

Choose a reason for hiding this comment

github-actions bot Sep 2, 2024

Choose a reason for hiding this comment

github-actions bot Sep 2, 2024

Choose a reason for hiding this comment

github-actions bot Sep 6, 2024

Choose a reason for hiding this comment

github-actions bot commented Jan 31, 2024 •

edited

Loading