stdio/file: fix numerous issues in the fread/fwrite functions #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziemleszcz
force-pushed
the
ziemleszcz/RTOS-892
branch
from
bf2a36e to
7058c9c
Compare
14 tasks
ziemleszcz
changed the title
Darchiv
reviewed
Sep 23, 2024
Also fixed error handling in blocking safe write to return -1 in case of undefined behavior. JIRA: RTOS-892, RTOS-874
ziemleszcz
force-pushed
the
ziemleszcz/RTOS-892
branch
from
7058c9c to
42040bb
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ziemleszcz
force-pushed
the
ziemleszcz/RTOS-892
branch
2 times, most recently
from
0f3e3de to
5df66ae
Compare
ziemleszcz
force-pushed
the
ziemleszcz/RTOS-892
branch
from
5df66ae to
408aeb3
Compare
Darchiv
reviewed
Oct 21, 2024
| return 0; | ||
| } | ||
| if (stream->bufpos != stream->bufeof) { | ||
| /* abort if the read buffer cannot be flushed (non-seekable stream) */ |
There was a problem hiding this comment.
Shouldn't errno be set then? (And maybe the error flag?)
There was a problem hiding this comment.
It's implementation-specific behavior. In this case, I'm emulating glibc.
There was a problem hiding this comment.
Ugh, case similar to errno in malloc(0), so we probably can't solve this reasonably. Ack.
ziemleszcz
force-pushed
the
ziemleszcz/RTOS-892
branch
from
408aeb3 to
fc10e0c
Compare
Darchiv
previously approved these changes
Oct 21, 2024
| return 0; | ||
| } | ||
| if (stream->bufpos != stream->bufeof) { | ||
| /* abort if the read buffer cannot be flushed (non-seekable stream) */ |
There was a problem hiding this comment.
Ugh, case similar to errno in malloc(0), so we probably can't solve this reasonably. Ack.
Fixed the following issues: - fclose returned -EINVAL instead of EOF - fclose did not return EOF on stream buffer flushing errors - removed unnecessary stream buffer flushing in fopen & fdopen - freopen did not return NULL on stream buffer flushing errors - fseek/fseeko/fsetpos cleared F_EOF flag on error - ftell/ftello/fgetpos cleared F_EOF flag - ftell/ftello/fgetpos flushed the stream buffer - non-blocking fflush was unsupported - flushing failed for non-seekable streams (lseek returning ESPIPE) - interleaved fread/fwrite failed for non-seekable streams (lseek returning ESPIPE) - non-blocking fread was unsupported - unbuffered fread did not set F_ERROR flag on read errors - unbuffered fread did not set F_EOF flag at end-of-file - buffered fread did not set F_ERROR flag on write buffer flushing errors - buffered fread did not return 0 on write buffer flushing errors - buffered fread did not set F_ERROR flag on buffer refilling errors - buffered fread incorrectly set F_EOF flag on EAGAIN errors - buffered fread did not always read full blocks from files - non-blocking fwrite was unsupported - unbuffered fwrite did not set F_ERROR flag on write errors - buffered fwrite did not set F_ERROR flag on read buffer flushing errors - buffered fwrite did not return 0 on read buffer flushing errors - buffered fwrite did not always write full blocks to files JIRA: RTOS-892
ziemleszcz
force-pushed
the
ziemleszcz/RTOS-892
branch
from
fc10e0c to
029ada8
Compare
Darchiv
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment