Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: implement generic extensible flash driver #521

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

storage: implement generic extensible flash driver #521

wants to merge 2 commits into from

Conversation

lukileczo
Copy link
Member

JIRA: RTOS-951

Description

Implement flash driver supporting GRLIB Spimctrl and Ftmctrl controllers and multiple flashes.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: riscv64-noelv-fpga, sparcv8leon-gr740-mini

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@lukileczo lukileczo requested a review from agkaminski November 8, 2024 10:08
nalajcie
nalajcie reviewed Nov 8, 2024
View reviewed changes
storage/flashdrv/drv/grlib-spimctrl/flashdrv.c
}

if (spimctrl_init(ctx->spimctrl, mctrlBase) < 0) {
free(ctx);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaking ctx->spimctrl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalajcie nalajcie nalajcie left review comments

@agkaminski agkaminski Awaiting requested review from agkaminski

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukileczo @nalajcie