fork: fix return value not being set in child #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
badochov
force-pushed
the
badochov/fork
branch
2 times, most recently
from
ce17193 to
5b85b47
Compare
badochov
force-pushed
the
badochov/fork
branch
2 times, most recently
from
f7d3ef0 to
5035acc
Compare
lukileczo
reviewed
Nov 29, 2024
badochov
force-pushed
the
badochov/fork
branch
9 times, most recently
from
e61a857 to
85f9607
Compare
lukileczo
reviewed
Nov 29, 2024
badochov
force-pushed
the
badochov/fork
branch
from
85f9607 to
08999da
Compare
Due to exiting on different stack than current's thread in fork in child the return value was not set by threads_setupUserReturn. JIRA: RTOS-979
badochov
force-pushed
the
badochov/fork
branch
from
08999da to
9f9bd46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a return value not being set in child during fork on ARM(7a,8r) and SPARC.
The problem was caused by threads_setupUserValue using current thread stack to obtain context, while in fork we return using parents stack.
JIRA: RTOS-979
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment