Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psh: tests improvements #256

Merged
merged 3 commits into from
Oct 18, 2023
Merged

psh: tests improvements #256

merged 3 commits into from
Oct 18, 2023

Conversation

mateusz-bloch
Copy link
Member

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

psh/test-cat.py Outdated Show resolved Hide resolved
psh/test-cat.py Outdated Show resolved Hide resolved
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/cat_improvements branch 3 times, most recently from 7e705aa to 7010180 Compare September 25, 2023 10:45
@github-actions
Copy link

github-actions bot commented Sep 25, 2023

Unit Test Results

5 884 tests  ±0   5 241 ✔️ +8   40m 34s ⏱️ + 11m 11s
   316 suites ±0      643 💤  - 8 
       1 files   ±0          0 ±0 

Results for commit 2d6f3fc. ± Comparison against base commit 8f65cff.

♻️ This comment has been updated with latest results.

@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/cat_improvements branch 9 times, most recently from 2864bf9 to 390e820 Compare September 28, 2023 13:41
@mateusz-bloch mateusz-bloch marked this pull request as ready for review September 28, 2023 13:43
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/cat_improvements branch 2 times, most recently from 146db1f to 078f779 Compare October 3, 2023 15:09
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks or those improvements! Please be more specific in commit messages if possible.

psh/test-autocompletion.py Outdated Show resolved Hide resolved
psh/test-cat.py Outdated Show resolved Hide resolved
psh/test-cat.py Outdated Show resolved Hide resolved
psh/test-cat.py Outdated Show resolved Hide resolved
psh/test-cat.py Outdated Show resolved Hide resolved
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/cat_improvements branch 3 times, most recently from e5ca15d to 6f90be0 Compare October 6, 2023 11:02
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/cat_improvements branch 5 times, most recently from be3ee22 to 48ee2eb Compare October 13, 2023 15:41
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest splitting those changes to the following commits:

  • psh: cat test improvements -> psh: test-cat: add cases with writing a content

  • psh: add cleanup in tests

  • psh: enable back test-touch

  • psh: small improvements and cleanup in tests

IMHO it will be much more readable in commit messages what have been changed.

psh/test.yaml Outdated Show resolved Hide resolved
@damianloew
Copy link
Contributor

I'd suggest splitting those changes to the following commits:

  • psh: cat test improvements -> psh: test-cat: add cases with writing a content
  • psh: add cleanup in tests
  • psh: enable back test-touch
  • psh: small improvements and cleanup in tests

IMHO it will be much more readable in commit messages what have been changed.

Of course you can change the messages a little bit if you want

@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/cat_improvements branch from 48ee2eb to 2d6f3fc Compare October 18, 2023 09:31
@mateusz-bloch mateusz-bloch marked this pull request as draft October 18, 2023 09:32
@mateusz-bloch mateusz-bloch marked this pull request as ready for review October 18, 2023 10:39
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damianloew damianloew merged commit 21e66a3 into master Oct 18, 2023
33 checks passed
@damianloew damianloew deleted the mateusz-bloch/cat_improvements branch October 18, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants