-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
psh: tests improvements #256
Conversation
7e705aa
to
7010180
Compare
2864bf9
to
390e820
Compare
146db1f
to
078f779
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks or those improvements! Please be more specific in commit messages if possible.
e5ca15d
to
6f90be0
Compare
be3ee22
to
48ee2eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest splitting those changes to the following commits:
-
psh: cat test improvements
->psh: test-cat: add cases with writing a content
-
psh: add cleanup in tests
-
psh: enable back test-touch
-
psh: small improvements and cleanup in tests
IMHO it will be much more readable in commit messages what have been changed.
Of course you can change the messages a little bit if you want |
48ee2eb
to
2d6f3fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment