Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psh: enable test execution in new psh for imxrt117x #357

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

mateusz-bloch
Copy link
Member

JIRA: CI-461

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@mateusz-bloch mateusz-bloch requested a review from damianloew June 12, 2024 11:55
@mateusz-bloch mateusz-bloch marked this pull request as ready for review June 12, 2024 11:55
Copy link

github-actions bot commented Jun 12, 2024

Unit Test Results

7 699 tests   - 1   6 984 ✅  - 1   39m 19s ⏱️ +34s
  435 suites  - 1     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit a903b8a. ± Comparison against base commit 3a22101.

This pull request removes 1 test.
phoenix-rtos-tests/psh/touch ‑ armv7m7-imxrt117x-evk:phoenix-rtos-tests/psh/touch

♻️ This comment has been updated with latest results.

@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/enable_new_psh_117x branch from 045a615 to 19f4d65 Compare June 12, 2024 12:18
@mateusz-bloch mateusz-bloch changed the title psh: enable executing tests in new psh for imxrt117x psh: enable test execution in new psh for imxrt117x Jun 12, 2024
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an info in commit description that it's done due to resolving #866 issue (someone when looking through commit history can think that it's some new feature)

@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/enable_new_psh_117x branch from 19f4d65 to 7e1cf71 Compare June 12, 2024 13:47
@mateusz-bloch mateusz-bloch requested a review from damianloew June 12, 2024 13:48
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a part of resolving issue - the issue has been already resolved and that's why we want to enable back this utility in tests

@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/enable_new_psh_117x branch from 7e1cf71 to 83a2d0a Compare June 14, 2024 10:14
@mateusz-bloch mateusz-bloch requested a review from damianloew June 14, 2024 10:15
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is enable due to resolved of the issue - that's not gramatically correct, it should be rather:
It is enabled due to the following issue resolution: ...

@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/enable_new_psh_117x branch from 83a2d0a to 0e8a248 Compare June 14, 2024 11:42
@mateusz-bloch mateusz-bloch requested a review from damianloew June 14, 2024 11:42
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/enable_new_psh_117x branch 2 times, most recently from 17e7992 to 78defb1 Compare June 18, 2024 12:59
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/enable_new_psh_117x branch from 78defb1 to 3cb911a Compare July 18, 2024 13:30
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/enable_new_psh_117x branch from 3cb911a to 8b6aaaf Compare August 12, 2024 16:32
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/enable_new_psh_117x branch from 6067c4a to 8b6aaaf Compare August 30, 2024 13:09
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested that on current changes it works stable?

It is enabled due to the following issue resolution: phoenix-rtos/phoenix-rtos-project#866

JIRA: CI-461
It is enabled due to the following issue resolution: phoenix-rtos/phoenix-rtos-project#580

JIRA: CI-461
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/enable_new_psh_117x branch 2 times, most recently from 70dd0b2 to ad846fa Compare September 16, 2024 07:59
@mateusz-bloch
Copy link
Member Author

Have you tested that on current changes it works stable?

So the issue, reported in phoenix-rtos/phoenix-rtos-project#1103, still exists. To run the tests with changes, we can either disable the test or possibly try running it first. I tested with a reboot before the test, but the issue still occurs.

@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/enable_new_psh_117x branch from ad846fa to b6a16c0 Compare September 17, 2024 08:57
@mateusz-bloch mateusz-bloch force-pushed the mateusz-bloch/enable_new_psh_117x branch from b6a16c0 to a903b8a Compare September 17, 2024 13:08
@damianloew damianloew merged commit a20b474 into master Sep 26, 2024
33 checks passed
@damianloew damianloew deleted the mateusz-bloch/enable_new_psh_117x branch September 26, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants