Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trunner:implement new type of reboot #382

Merged
merged 2 commits into from
Dec 11, 2024
Merged

trunner:implement new type of reboot #382

merged 2 commits into from
Dec 11, 2024

Conversation

maska989
Copy link
Contributor

@maska989 maska989 commented Oct 30, 2024 •
edited
Loading

Adds possibility to reset target using jtag standard

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: armv7a9-zynq7000-zedboard.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

Unit Test Results

7 958 tests  ±0   7 416 ✅ ±0   40m 22s ⏱️ +5s
  470 suites ±0     542 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 3889696. ± Comparison against base commit 216255e.

♻️ This comment has been updated with latest results.

@maska989 maska989 force-pushed the maska989/armv7a9_reset_via_jtag branch from e133fef to 1c03b92 Compare October 30, 2024 09:30
nalajcie
nalajcie reviewed Oct 30, 2024
View reviewed changes
trunner/harness/base.py Outdated Show resolved Hide resolved
@maska989 maska989 force-pushed the maska989/armv7a9_reset_via_jtag branch from 1c03b92 to f6ac856 Compare November 4, 2024 09:16
github-actions[bot]
github-actions bot reviewed Nov 4, 2024
View reviewed changes
trunner/harness/base.py Outdated Show resolved Hide resolved
@maska989 maska989 force-pushed the maska989/armv7a9_reset_via_jtag branch 2 times, most recently from e3dfa0a to e4c1f64 Compare November 6, 2024 11:53
@maska989 maska989 marked this pull request as ready for review November 6, 2024 11:54
@maska989 maska989 requested a review from damianloew November 6, 2024 11:55
damianloew
damianloew requested changes Nov 14, 2024
View reviewed changes
trunner/harness/base.py Outdated Show resolved Hide resolved
trunner/harness/base.py Outdated Show resolved Hide resolved
trunner/harness/base.py Outdated Show resolved Hide resolved
trunner/target/armv7a9.py Outdated Show resolved Hide resolved
nalajcie
nalajcie reviewed Nov 14, 2024
View reviewed changes
trunner/target/armv7a9.py Outdated Show resolved Hide resolved
nalajcie
nalajcie reviewed Nov 14, 2024
View reviewed changes
trunner/harness/base.py Outdated Show resolved Hide resolved
nalajcie
nalajcie reviewed Nov 14, 2024
View reviewed changes
trunner/harness/base.py Outdated Show resolved Hide resolved
@maska989 maska989 force-pushed the maska989/armv7a9_reset_via_jtag branch from e4c1f64 to 15cb146 Compare November 25, 2024 13:55
@nalajcie
Copy link
Member

please add space ( ) after trunner: in commit message title

@maska989 maska989 force-pushed the maska989/armv7a9_reset_via_jtag branch 2 times, most recently from 06eab17 to 02b1301 Compare November 26, 2024 13:06
nalajcie
nalajcie reviewed Nov 26, 2024
View reviewed changes
trunner/harness/base.py Outdated Show resolved Hide resolved
@maska989 maska989 force-pushed the maska989/armv7a9_reset_via_jtag branch 2 times, most recently from b5b17d5 to d58820c Compare November 27, 2024 08:27
@maska989 maska989 requested a review from damianloew November 27, 2024 11:02
mateusz-bloch
mateusz-bloch requested changes Nov 27, 2024
View reviewed changes
trunner/tools/gdb.py Outdated Show resolved Hide resolved
trunner/tools/gdb.py Outdated Show resolved Hide resolved
trunner/tools/gdb.py Outdated Show resolved Hide resolved
trunner/target/armv7m4.py Outdated Show resolved Hide resolved
trunner/target/armv7a9.py Outdated Show resolved Hide resolved
@maska989 maska989 force-pushed the maska989/armv7a9_reset_via_jtag branch from d58820c to 6d423d2 Compare December 4, 2024 10:10
mateusz-bloch
mateusz-bloch previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@mateusz-bloch mateusz-bloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only few comments

trunner/target/armv7m4.py Outdated Show resolved Hide resolved
trunner/target/armv7a9.py Outdated Show resolved Hide resolved
mateusz-bloch
mateusz-bloch reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@mateusz-bloch mateusz-bloch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, i would change commit name to be more specific

image

maybe smth like:

trunner: implement reboot by device debugger

@maska989 maska989 force-pushed the maska989/armv7a9_reset_via_jtag branch from 6d423d2 to 057e791 Compare December 10, 2024 09:39
@maska989 maska989 force-pushed the maska989/armv7a9_reset_via_jtag branch from 057e791 to 1600c89 Compare December 10, 2024 09:41
damianloew
damianloew requested changes Dec 10, 2024
View reviewed changes
trunner/target/armv7a9.py Outdated Show resolved Hide resolved
trunner/target/armv7m4.py Outdated Show resolved Hide resolved
trunner/target/armv7a9.py Show resolved Hide resolved
trunner/target/armv7a9.py Outdated Show resolved Hide resolved
trunner/target/armv7a9.py Outdated Show resolved Hide resolved
trunner/target/armv7a9.py Outdated Show resolved Hide resolved
trunner/target/armv7a9.py Outdated Show resolved Hide resolved
trunner/target/armv7m4.py Show resolved Hide resolved
trunner/tools/gdb.py Outdated Show resolved Hide resolved
trunner/tools/gdb.py Outdated Show resolved Hide resolved
@maska989 maska989 force-pushed the maska989/armv7a9_reset_via_jtag branch 2 times, most recently from bfd7e77 to 51846e5 Compare December 10, 2024 14:56
damianloew
damianloew requested changes Dec 11, 2024
View reviewed changes
trunner/target/armv7m4.py Outdated Show resolved Hide resolved
trunner/tools/gdb.py Outdated Show resolved Hide resolved
trunner/target/armv7m4.py Outdated Show resolved Hide resolved
trunner/tools/gdb.py Outdated Show resolved Hide resolved
@maska989 maska989 force-pushed the maska989/armv7a9_reset_via_jtag branch 2 times, most recently from f41fb32 to 32beddb Compare December 11, 2024 13:44
@maska989
trunner: unify openocd handling
cc44927 
JIRA: CI-515
@maska989
trunner: implement reboot by debugger for armv7a9 & armv7m4
3889696 
Introduced a new reboot method leveraging available debuggers (STLink v2 / SMT2) to minimize resets trough NRST & power off, which could have caused debugger failures.

JIRA: CI-515
@maska989 maska989 force-pushed the maska989/armv7a9_reset_via_jtag branch from 32beddb to 3889696 Compare December 11, 2024 14:41
@damianloew damianloew merged commit 1c676a4 into master Dec 11, 2024
39 checks passed
@damianloew damianloew deleted the maska989/armv7a9_reset_via_jtag branch December 11, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@nalajcie nalajcie nalajcie left review comments

@damianloew damianloew damianloew approved these changes

@mateusz-bloch mateusz-bloch Awaiting requested review from mateusz-bloch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maska989 @nalajcie @damianloew @mateusz-bloch