Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hal/ia32: Add HPET #302

Merged
merged 1 commit into from
Nov 15, 2023
Merged

hal/ia32: Add HPET #302

merged 1 commit into from
Nov 15, 2023

Conversation

astalke
Copy link
Contributor

@astalke astalke commented Nov 14, 2023

JIRA: RTOS-530

Description

Change in plo that is required for phoenix-rtos/phoenix-rtos-kernel#476 to work.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: ia32-generic-pc, ia32-generic-qemu

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@astalke astalke requested a review from agkaminski November 14, 2023 13:43
github-actions[bot]
github-actions bot reviewed Nov 14, 2023
View reviewed changes
hal/ia32/acpi.c Outdated Show resolved Hide resolved
@astalke astalke mentioned this pull request Nov 14, 2023
Merged
13 tasks
agkaminski
agkaminski reviewed Nov 14, 2023
View reviewed changes
hal/ia32/acpi.c Outdated Show resolved Hide resolved
hal/ia32/acpi.c Outdated Show resolved Hide resolved
@astalke astalke force-pushed the astalke/RTOS-530 branch 2 times, most recently from 3a7352b to 6c278f9 Compare November 14, 2023 15:26
agkaminski
agkaminski approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astalke @agkaminski
hal/ia32: Add HPET
7233a21 
JIRA: RTOS-530
@agkaminski agkaminski merged commit 34367fe into master Nov 15, 2023
@agkaminski agkaminski deleted the astalke/RTOS-530 branch November 15, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@agkaminski agkaminski agkaminski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@astalke @agkaminski