Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add <hr/> support to options_for_select #451

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Add <hr/> support to options_for_select #451

merged 3 commits into from
Oct 21, 2024

Conversation

gilbertbw
Copy link
Contributor

This allows you to add separators to option lists, as described here.

SteffenDE
SteffenDE approved these changes Oct 21, 2024
View reviewed changes
lib/phoenix_html/form.ex Outdated Show resolved Hide resolved
@SteffenDE SteffenDE merged commit 6b67a08 into phoenixframework:main Oct 21, 2024
2 checks passed
@SteffenDE
Copy link
Contributor

Thank you! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteffenDE SteffenDE SteffenDE approved these changes

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gilbertbw @SteffenDE @josevalim