Use ExUnit's assert_receive_timeout as the default receive timeout #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the behavior of Phoenix.ChannelTest Per a [brief discussion on Mastodon](https://merveilles.town/@peregrine/110469721567235316), this replaces the hardcoded default timeout of 100 milliseconds on message-receiving test functions (`assert_patch`, `assert_redirect`, `assert_push_event`, and `assert_reply`) with a lookup of ExUnit's `assert_receive_timeout`. This makes the behavior of `Phoenix.LiveViewTest` more consistent with `Phoenix.ChannelTest`, where `assert_receive`, `assert_push`, `assert_reply`, and `assert_broadcast` all delegate to the ExUnit config for their default timeout.
jeregrine
reviewed
Jun 1, 2023
josevalim
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
LGTM! Go ahead and merge it @jeregrine when you are happy too :)
|
Just some docs fixes |
jeregrine
approved these changes
Jun 1, 2023
|
<3 thank you so much @s3cur3 |
|
Thank you! 😄 💜 |
|
💚💙💜💛❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per a brief discussion on Mastodon, this replaces the hardcoded default timeout of 100 milliseconds on message-receiving test functions (
assert_patch,assert_redirect,assert_push_event, andassert_reply) with a lookup of ExUnit'sassert_receive_timeout.This makes the behavior of
Phoenix.LiveViewTestmore consistent withPhoenix.ChannelTest, whereassert_receive,assert_push,assert_reply, andassert_broadcastall delegate to the ExUnit config for their default timeout.