Tweak language in the welcome guide #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change language to be a bit more explicit * Change an instance of "functional component" to "function component"
davydog187
reviewed
Nov 9, 2024
Oops, thanks! Co-authored-by: Dave Lucia <dave@tvlabs.ai>
|
Thanks <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes some small tweaks to the language used in the welcome guide, specifically under the "Compartmentalize state, markup, and events" section. The primary goal is to be a little more explicit when talking about function components vs live components vs nested LiveViews. There are a few small grammar tweaks as well as renaming a lone reference to "functional components" to "function component." I've always been a bit confused as to the proper name but it seems that it's "function component" everywhere except this one place. There is actually one more place but it's in the changelog and it feels odd changing that—I can, though!
Question: should LiveComponent always be written like that when not explicitly talking about the module, or is "live component" the right way? I went with the former since LiveView is always spelled like that.