Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instant feedback after manual number input #113

Closed
jost-s opened this issue May 19, 2020 · 3 comments
Closed

Instant feedback after manual number input #113

jost-s opened this issue May 19, 2020 · 3 comments
Labels
⚒️ enhancement Enhancements ✅ released Already released

Comments

@jost-s
Copy link
Contributor

jost-s commented May 19, 2020

The manual input is a welcome addition. By default there's a delay of 500 ms after a number key is pressed.

My suggestion is to instantly reflect the pressed key and wait for another key to be pressed with a configurable timeout. I've submitted a PR for this change.
@phoenixwong phoenixwong added the ⚒️ enhancement Enhancements label May 19, 2020
phoenixwong added a commit that referenced this issue May 19, 2020
@phoenixwong
Merge pull request #112 from jost-s/feature/configure-delay-after-man…
395b857 
…ual-input

Add prop for manual input delay (#113)
@phoenixwong phoenixwong added the 🚥 next release Included in the next release label May 19, 2020
@AmitJoki
Copy link

When will the next release be?

@phoenixwong
Copy link
Owner

ETA: by next Monday.

phoenixwong added a commit that referenced this issue May 24, 2020
@phoenixwong
Enhancements for the instant manual input feedback (#113)
ac5ccdc 
- Rename the new property to `manualInputTimeout`
- Add failsafe checking
- Clear manual input logs right after pressing arrows and tab keys to prevent adhesive values
- Add Playground demo accordingly
@phoenixwong phoenixwong mentioned this issue May 24, 2020
Merged
@phoenixwong phoenixwong added ✅ released Already released and removed 🚥 next release Included in the next release labels May 24, 2020
@phoenixwong
Copy link
Owner

Hi guys, the enhancements released in v1.1.1.

FYI, I renamed the configurable timeout property to manual-input-timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚒️ enhancement Enhancements ✅ released Already released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AmitJoki @phoenixwong @jost-s