Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

Commit

Permalink
📝 update readme
Browse files Browse the repository at this point in the history
  • Loading branch information
@macdonst
macdonst committed May 8, 2017
1 parent a27a62d commit 0cbb7a9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
# What is this?

This plugin offers support to receive and handle native push notifications with a **single unified API**.
This plugin offers support to receive and handle native push notifications with a **single unified API**.

Starting with version `1.9.0`, this plugin will support `CocoaPods` installation of the `Google Cloud Messaging` library. More details are available in the [Installation](docs/INSTALLATION.md#cocoapods) documentation.
Starting with version `2.0.0`, this plugin will support `CocoaPods` installation of the `Firebase Cloud Messaging` library. More details are available in the [Installation](docs/INSTALLATION.md#cocoapods) documentation.

This comment has been minimized.

Sign in to view

Copy link
@fredgalvao

fredgalvao May 8, 2017

Collaborator

Shouldn't we keep the docs on the cocoapod section for 1.9.0? We could differ then on what we use pods for afterwards (1.9.0:GCM -> 2.0.0:FCM).

This comment has been minimized.

Sign in to view

Copy link
@fredgalvao

fredgalvao May 8, 2017

Collaborator

Also, we should update the installation docs to cover cocoapods properly (I went through it as a user recently and felt it misleading/lacking, e.g. pod install vs pod setup vs pod repo update vs the universe).

This comment has been minimized.

Sign in to view

Copy link
@macdonst

macdonst May 9, 2017

Author Member

@fredgalvao I figure we'll support two branches for awhile with regards to the GCM/FCM cocoapods but yes please add a new doc issue with cocoapod install.

This comment has been minimized.

Sign in to view

Copy link
@fredgalvao

fredgalvao May 9, 2017

Collaborator

@macdonst The thing is, I'm not sure what the steps should be. I'm not an iOS developer, I don't even have a macOS device available, so I'm really not the one able to document those steps. I got it sorted on my end using a friend's machine, and trying pretty much all of the steps I found (let's hope I got it right). Maybe @shazron could help us?

This comment has been minimized.

Sign in to view

Copy link
@shazron

shazron May 9, 2017

Member

Hi, file the docs issue so we can discuss it there (and mention me). After looking at the docs, I think it's just missing a couple of steps on how to install CocoaPods and assumes the user will know what to do by going to the CocoaPods site.

This comment has been minimized.

Sign in to view

Copy link
@fredgalvao

fredgalvao May 9, 2017

Collaborator

Done: #1716

- [Reporting Issues](docs/ISSUES.md)
- [Installation](docs/INSTALLATION.md)
Expand Down

0 comments on commit 0cbb7a9

Please sign in to comment.