This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
Add cordovaDependencies section to package.json
#1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reflects `engines` elements from plugin manifest to package.json to comply w/ [new plugin fetching model](https://github.com/cordova/cordova-discuss/blob/master/proposals/plugin-version-fetching.md) and corrects `engine`'s value according to [package.json format](https://docs.npmjs.com/files/package.json#engines) Its also desirable to add 'protective' entry for next major plugin version to protect end-users from fetching edge versions of the plugin by incompatible version of cordova. See corresponding [discussion on mailing list](http://apache.markmail.org/thread/p73loqtvbzvfzsv5) for more details and reasons behind this.
|
This thread has been automatically locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reflects
engineselements from plugin manifest to package.json to comply w/ new plugin fetching model and correctsengine's value according to package.json formatIts also desirable to add 'protective' entry for next major plugin version as per corresponding discussion on cordova mailing list.
Motivation and Context
The change is needed to protect end-users from fetching edge versions of the plugin by incompatible version of cordova.
How Has This Been Tested?
Published 1.8.2 and 2.0.1 version of the plugin under personal scope (
@kotikov.vladimir/phonegap-plugin-push) and rancordova plugin addto ensure that desired plugin version is being fetched and installedScreenshots (if appropriate):
Types of changes
Checklist: