Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

Issue#1282 Show app name if title is empty #1285

Merged
merged 1 commit into from
Oct 13, 2016
Merged

Issue#1282 Show app name if title is empty #1285

merged 1 commit into from
Oct 13, 2016

Conversation

malwatte
Copy link
Contributor

@malwatte malwatte commented Oct 13, 2016

Show app name as the title in Android if title is empty in push payload

Description

If title is empty we need to show app name as the title since it is the default behaviour.

Related Issue

#1282

How Has This Been Tested?

Tested in Samsung Galaxy S5 (6.0.1) for both background and foreground notifications
with no title parameter, null, "" and with a value.

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@macdonst macdonst merged commit 3d7a3a3 into phonegap:master Oct 13, 2016
@macdonst
Copy link
Member

@malwatte thanks for the PR, I've merged it in and should have a new release out shortly.

@malwatte malwatte deleted the issue1282 branch October 13, 2016 15:34
@malwatte
Copy link
Contributor Author

Great!

@macdonst
Copy link
Member

@malwatte I pushed a 1.8.3 with your fix. I'm working on a 1.9.0 today with some API additions.

@lock
Copy link

lock bot commented Jun 3, 2018

This thread has been automatically locked.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants