Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

Support Twilio Notify #1306

Merged
merged 4 commits into from
Oct 26, 2016
Merged

Support Twilio Notify #1306

merged 4 commits into from
Oct 26, 2016

Conversation

viktormuller
Copy link
Contributor

@viktormuller viktormuller commented Oct 21, 2016

Description

Adds support for Twilio Notify on Android. Specifically adds following mappings to normalizeKey:

  • twi_body --> message
  • twi_title --> title
  • twi_sound --> sound

Motivation and Context

Twilio Notify allows developers to send notifications to iOS and Android devices without worrying about the target platform. This change allows developers to use this Phonegap plugin to write unified cross-platform (iOS and Android) code to receive messages. Together Notify and the Phonegap plugin allows building truly cross-platform notification systems with a single unified code-base both on client and service side.

How Has This Been Tested?

We have tested it with a cross-platform ionic app that we have demonstrated at Jacobshack 2016.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Viktor Muller added 2 commits October 16, 2016 15:34
Allows developers to use Twilio Notify seamlessly with phonegap and
hence allows cross platform development on both client and service side.
@macdonst
Copy link
Member

@viktormuller looks good to me. Can you write up a short blurb to include in PAYLOAD.md?

@viktormuller
Copy link
Contributor Author

@macdonst Sure, i will do that and add it to the PR.

@viktormuller
Copy link
Contributor Author

@macdonst Added some description to PAYLOAD.md. Let me know if that makes or if you have any suggestions for improvement.

@macdonst macdonst merged commit a9bb3bf into phonegap:master Oct 26, 2016
@macdonst
Copy link
Member

@viktormuller thanks for the commit and updating the docs!

@viktormuller
Copy link
Contributor Author

@macdonst No problem thanks for the help and the quick merge.

mlabieniec added a commit to mlabieniec/phonegap-plugin-push that referenced this pull request Oct 27, 2016
@lock
Copy link

lock bot commented Jun 3, 2018

This thread has been automatically locked.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants