This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
Optional event emit instead of function call for action buttons #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akz92 this looks like a good start but can you fill out the PR template so I know what has and hasn't been done. Also, only one file seems to have been changed even though you have 10 commits so your doc changes are missing. |
|
@macdonst ok. I opted to remove the doc changes because I wasn't sure about how to add the details about this. I'll fill out the PR template and then I'll change the docs. |
|
@akz92 yeah, add the docs back in. I can modify them if required. |
Update emit description Update action button callback instructions Update action button callback instructions Update PAYLOAD.md Add conditional to execute function or emit event Remove changes to doc [fix] payload doc get payload file from master [fix] indentation [fix] code style
[fix] Doc
|
Added the docs back. @macdonst I tried to keep it simple since this is a secondary behavior, please let me know if you think we need to add more details to the docs. |
|
@akz92 would you be interested in making a PR on the v2.0.x branch where I use ES2015? |
|
Sure @macdonst, just give me a few days. |
|
@akz92 thanks for the PR. I've merged it into master and I'll get it into a 1.9.2 release. |
|
No problem @macdonst. I didn't forget about the v2.0.x PR, I'll get to it
soon.
2016-12-14 13:13 GMT-02:00 Simon MacDonald <notifications@github.com>:
… @akz92 <https://github.com/akz92> thanks for the PR. I've merged it into
master and I'll get it into a 1.9.2 release.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1378 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD4iQjLww7245_B5BqNlyaLYkoaoa__Vks5rIAeMgaJpZM4Kzwhj>
.
--
Lucas Aride Moulin,
aride.moulin@gmail.com
|
|
@akz92 I'm doing a rebase of your changes to the v2.0.x branch right now. So it may not be necessary. Hang tight. |
macdonst
added a commit
that referenced
this pull request
Dec 14, 2016
…ction call for action buttons
|
@akz92 okay, I merged your code into 2.0.0 and fixed my merge screw up. It is now officially part of the 2.0.0 branch. Thanks again for your awesomeness. Do you have a twitter account? |
|
That's great! Can't wait to use it from the npm package :) Yes:
https://twitter.com/aakz92
2016-12-14 14:11 GMT-02:00 Simon MacDonald <notifications@github.com>:
… @akz92 <https://github.com/akz92> okay, I merged your code into 2.0.0 and
fixed my merge screw up. It is now officially part of the 2.0.0 branch.
Thanks again for your awesomeness. Do you have a twitter account?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1378 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD4iQilXd3QQhvt_Qs40hEsMat_DEnjrks5rIBUmgaJpZM4Kzwhj>
.
--
Lucas Aride Moulin,
aride.moulin@gmail.com
|
|
Is the Changelog updated? I see an entry of v1.9.2 (2016-07-09) https://github.com/phonegap/phonegap-plugin-push/blob/master/CHANGELOG.md but the date is (2016-07-09) which I believe is the date of v1.9.1 |
|
@naveedahmed1 You're correct, the date was not properly generated: e02ff67#commitcomment-20189903 |
macdonst
added a commit
that referenced
this pull request
Jan 4, 2017
…ction call for action buttons
macdonst
added a commit
that referenced
this pull request
Jan 6, 2017
…ction call for action buttons
macdonst
added a commit
that referenced
this pull request
Jan 12, 2017
…ction call for action buttons
ippeiukai
pushed a commit
to ippeiukai/phonegap-plugin-push
that referenced
this pull request
Feb 1, 2017
…egap#1378) * Emit event using action button callback name Update emit description Update action button callback instructions Update action button callback instructions Update PAYLOAD.md Add conditional to execute function or emit event Remove changes to doc [fix] payload doc get payload file from master [fix] indentation [fix] code style * Add documentation [fix] Doc
macdonst
added a commit
that referenced
this pull request
Apr 29, 2017
…ction call for action buttons
macdonst
added a commit
that referenced
this pull request
May 5, 2017
…ction call for action buttons
macdonst
added a commit
that referenced
this pull request
May 24, 2017
…ction call for action buttons
macdonst
added a commit
that referenced
this pull request
May 25, 2017
* Added partial Android FCM support (#975) * Modified plugin.xml to include FCM changes * Plugin.xml changes for FCM * Java changes for FCM * Increased plugin version to 2.0.0 * Increased plugin version in package.json * Added topic subscription/unsubscription * Removed some empty lines * Fixed empty token on android first run (#1008) * Removed GCM files and added FCM files * Added .framework files as custom frameworks * Changed code to work with FCM * Added hook and resource file to copy GoogleService-Info.plist * fixed registration and removed unused code * Use CocoaPods * Fix rebase errors * Fix topic subscription and unsubscription on FCM * Refactor GCMIntentService to FCMService * Issue #689: Remove sender id from PushNotification init Android options * Issue #689: Remove sender id from PushNotification init iOS options * 📝 Update to using fcm-node * 🐛 Issue #1188: Strings.xml google_app_id conflict with google-services.json * Add empty google services plist * Pin FCM to 9.8.0 * 🔧 Add browser platform back for FCM branch * 🔨🔧⬆️ Use Babel to transpile ES2015 code * 🔧 add tern to gitignore * 🔖 Bumping plugin version to 2.0.0-rc1 * 2.0.0-rc1 * Updating CHANGELOG * Fixing my merge error for PR #1378 Optional event emit instead of function call for action buttons * 🐛🍎 Issue #1461: App crashes when initialising with topics (v2.0.0-rc1) * 🐛🐧📝⬆️ #1460: Build Issue Android * 🐛🍎🔧 Fixing a merge issue where aps-environment was accidentally removed * 🐧📝🐛 Issue #1470: Cannot install phonegap-plugin-push on master * 📝 Using a newer version on the examples * 🍎🐛 Issue #1497: App crashes after refreshing when using FCM (v2) * Bumping plugin version to 2.0.0-rc2 * 2.0.0-rc2 * Updating CHANGELOG * Added partial Android FCM support (#975) * Modified plugin.xml to include FCM changes * Plugin.xml changes for FCM * Java changes for FCM * Increased plugin version to 2.0.0 * Increased plugin version in package.json * Added topic subscription/unsubscription * Removed some empty lines * Removed GCM files and added FCM files * Changed code to work with FCM * Added hook and resource file to copy GoogleService-Info.plist * Use CocoaPods * Fix rebase errors * Issue #689: Remove sender id from PushNotification init Android options * 🐛 Issue #1188: Strings.xml google_app_id conflict with google-services.json * Pin FCM to 9.8.0 * 🔧 Add browser platform back for FCM branch * 🔨🔧⬆️ Use Babel to transpile ES2015 code * 🔧 add tern to gitignore * 🔖 Bumping plugin version to 2.0.0-rc1 * 🐛🐧📝⬆️ #1460: Build Issue Android * Bumping plugin version to 2.0.0-rc2 * Added partial Android FCM support (#975) * Modified plugin.xml to include FCM changes * Plugin.xml changes for FCM * Java changes for FCM * Increased plugin version to 2.0.0 * Increased plugin version in package.json * Added topic subscription/unsubscription * Removed some empty lines * Removed GCM files and added FCM files * Added hook and resource file to copy GoogleService-Info.plist * Use CocoaPods * Fix rebase errors * 🐛 Issue #1188: Strings.xml google_app_id conflict with google-services.json * Updating CHANGELOG * ✏️ fixing error in CHANGELOG * Bumping plugin version to 2.0.0-rc2 * Updating CHANGELOG * Added partial Android FCM support (#975) * Modified plugin.xml to include FCM changes * Plugin.xml changes for FCM * Java changes for FCM * Increased plugin version to 2.0.0 * Increased plugin version in package.json * Added topic subscription/unsubscription * Removed some empty lines * Removed GCM files and added FCM files * Changed code to work with FCM * Added hook and resource file to copy GoogleService-Info.plist * fixed registration and removed unused code * Use CocoaPods * Fix rebase errors * Issue #689: Remove sender id from PushNotification init Android options * Issue #689: Remove sender id from PushNotification init iOS options * 🐛 Issue #1188: Strings.xml google_app_id conflict with google-services.json * 🔧 add tern to gitignore * 🔖 Bumping plugin version to 2.0.0-rc1 * Bumping plugin version to 2.0.0-rc2 * Remove hook and use resource-file tag to copy google services file * Add resource-file way of copying google services files * Bump requirements * 🔧 Update cordovaDependencies * 🔖 Bumping plugin version to 2.0.0-rc3 * 2.0.0-rc3 * Updating CHANGELOG * Fixes 'framework not found GoogleToolboxForMac' linker error in 2.0.0-rc3 (#1715) * Remove unused files (#1732) * Remove GTM framework. (#1739)
|
This thread has been automatically locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the option to emit events instead of executing functions on action buttons click.
Related Issue
#1192
Motivation and Context
It's easier and IMO better to work with events instead of functions in this kind of situation.
How Has This Been Tested?
I only tested the event emission.
Types of changes
Checklist: