This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
Fix INSTALLATION.md docs for v2.0.0 and FirebaseMessaging #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/INSTALLATION.md
Outdated
| @@ -267,7 +267,7 @@ To install CocoaPods, please follow the installation instructions [here](https:/ | |||
| This will clone the required CocoaPods specs-repo into your home folder at `~/.cocoapods/repos`, so it might take a while. See the [CocoaPod Disk Space](#cocoapod-disk-space) section below for more information. | |||
|
|
|||
|
|
|||
| Version `1.9.0` (and above) of this plugin supports [CocoaPods](https://cocoapods.org) installation of the [Google Cloud Messaging](https://cocoapods.org/pods/GoogleCloudMessaging) library. | |||
| Version `2.0.0` (and above) of this plugin supports [CocoaPods](https://cocoapods.org) installation of the [Google Firebase Cloud Messaging](https://cocoapods.org/pods/FirebaseMessaging) library. | |||
There was a problem hiding this comment.
Just "Firebase Cloud Messaging", I don't think they name it "Google" first
|
@macdonst test failure: Object.assign is ES6, and we are still testing this on Travis with Node 0.10. Update to Node 4 for testing? |
|
@shazron yeah, I forgot to do that. Sent a commit to do that right now. |
|
This thread has been automatically locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The merge clobbered some docs, fixed them.