This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
Remove unnecessary didRegisterUserNotificationSettings implementation, which did break cordova-local-notifications-plugin as a side effect #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicting implementation of didRegisterUserNotificationSettings prevents cordova-local-notifications-plugin from being notified of success. emoving it fixes the problem as it was redundant (simply calls registerForRemoteNotifications, which is called anyway from PushPlugin:init right after registerUserNotificationSettings). Fixes phonegap/issues/183 and katzer/cordova-plugin-local-notifications/issues/695
|
+1 for merging this! Having this same problem now that we are forced to use the new |
|
Agreed. +1 to merge this ASAP. |
macdonst
added a commit
that referenced
this pull request
Oct 10, 2015
Remove unnecessary didRegisterUserNotificationSettings implementation, which did break cordova-local-notifications-plugin as a side effect
|
Much thanks to @EdMcBane |
|
Thank you for the quick merge! |
|
That's what open source is all about. |
Closed
|
👍 |
|
This thread has been automatically locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem is due to conflicting implementations of didRegisterUserNotificationSettings that prevents cordova-local-notifications-plugin from being notified of successful calls to registerUserNotificationSettings.
If implementing didRegisterUserNotificationSettings does indeed become necessary, consider using some common notification mechanism such as the one at https://github.com/katzer/cordova-common-registerusernotificationsettings to avoid conflicts with other plugins.
Fixes #183 and katzer/cordova-plugin-local-notifications#695