Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort transactions by index in block as well as height #27

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Sort transactions by index in block as well as height #27

merged 2 commits into from
Jul 22, 2019

Conversation

meyer9
Copy link
Member

@meyer9 meyer9 commented Jul 22, 2019

This fixes bugs where balances were shown incorrectly because the input would be processed after the transaction spending the input if the transactions were in the same block and sorted incorrectly.

@meyer9 meyer9 added the bug label Jul 22, 2019
@meyer9 meyer9 requested review from anchaj and tohsnoom July 22, 2019 23:36
@coveralls
Copy link

coveralls commented Jul 22, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 30.618% when pulling 9c410a6 on sort-transactions-by-index into b3e476a on master.

@anchaj anchaj merged commit a616d43 into master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anchaj anchaj anchaj approved these changes

@tohsnoom tohsnoom Awaiting requested review from tohsnoom

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meyer9 @coveralls @anchaj