Skip to content

Commit

Permalink
Mobile: hide unuseful "Persistent Chat" checkbox
Browse files Browse the repository at this point in the history
Summary:
On mobile devices like tablets or toasters the "Persistent Chat"
floating widget is already hidden.

So, the related checkbox available from the top navigation bar
is just confusing on tablet and mobile devices / toasters, since
that nice checkbox does nothing there.

On mobile and tablet, this is the graphical change:

| Before   | After     |
|----------|-----------|
|{F281239} | {F281235} |

This change do not change anything for desktop devices.
So, on desktop, that checkbox is obviously still visible.

Closes T15240

Test Plan:
- test on tablet and below: now the checkbox should be not visible
- test on desktop: the checkbox should still be visible

Reviewers: O1 Blessed Committers, Cigaryno, bfs, speck

Reviewed By: O1 Blessed Committers, Cigaryno, bfs, speck

Subscribers: avivey, bfs, dcog, chris, speck, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15240

Differential Revision: https://we.phorge.it/D25120
  • Loading branch information
valerio-bozzolan committed Jun 9, 2023
1 parent 7af82ab commit 980293b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
6 changes: 3 additions & 3 deletions resources/celerity/map.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/
return array(
'names' => array(
'conpherence.pkg.css' => '0e3cf785',
'conpherence.pkg.css' => '76ed87e3',
'conpherence.pkg.js' => '020aebcf',
'core.pkg.css' => '0cb47e9d',
'core.pkg.js' => '2eeda9e0',
Expand Down Expand Up @@ -53,7 +53,7 @@
'rsrc/css/application/conpherence/header-pane.css' => 'c9a3db8e',
'rsrc/css/application/conpherence/menu.css' => '67f4680d',
'rsrc/css/application/conpherence/message-pane.css' => 'd244db1e',
'rsrc/css/application/conpherence/notification.css' => '6a3d4e58',
'rsrc/css/application/conpherence/notification.css' => '85c48def',
'rsrc/css/application/conpherence/participant-pane.css' => '69e0058a',
'rsrc/css/application/conpherence/transaction.css' => '3a3f5e7e',
'rsrc/css/application/contentsource/content-source-view.css' => 'cdf0d579',
Expand Down Expand Up @@ -554,7 +554,7 @@
'conpherence-header-pane-css' => 'c9a3db8e',
'conpherence-menu-css' => '67f4680d',
'conpherence-message-pane-css' => 'd244db1e',
'conpherence-notification-css' => '6a3d4e58',
'conpherence-notification-css' => '85c48def',
'conpherence-participant-pane-css' => '69e0058a',
'conpherence-thread-manager' => 'aec8e38c',
'conpherence-transaction-css' => '3a3f5e7e',
Expand Down
5 changes: 5 additions & 0 deletions webroot/rsrc/css/application/conpherence/notification.css
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,8 @@
font-weight: normal;
color: {$greytext};
}

/* On small devices the Persistent Chat is already hidden, and so its option */
.device .phabricator-notification-header .persistent-option {
display: none;
}

0 comments on commit 980293b

Please sign in to comment.