Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scorer and classifier filters #1257

Merged
merged 10 commits into from
Oct 25, 2024
Merged

feat: add scorer and classifier filters #1257

merged 10 commits into from
Oct 25, 2024

Conversation

fred3105
Copy link
Contributor

@fred3105 fred3105 commented Oct 25, 2024

Summary

Adds backend and frontend filters for scorers and classifiers in the Query Builder class
Changes to ProjectDataFilters
Improved filters component
Better naming for analytics filters
Misc bug fixes

Situation before

What's here now

Check list

  • typing, linting, docstrings (cicd will fail)
  • If adding an external service, include the relevant API keys in deployment scripts in .github/workflows (staging and prod) and GH actions
  • If changing data models in phospho-python that are used in the backend, run poetry lock in phospho-python so the backend tests CICD cache is invalidated
  • If creating an API endpoint, add it to v3 so that you can easily document it in docs.phospho.ai

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
phospho-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 3:43pm

@oulianov oulianov merged commit b44a244 into dev Oct 25, 2024
10 checks passed
@oulianov
Copy link
Collaborator

Note : only the first of category_value and scorer_value filters are applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants