Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: edit more docs links #1347

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Fix: edit more docs links #1347

merged 2 commits into from
Jan 8, 2025

Conversation

oulianov
Copy link
Collaborator

@oulianov oulianov commented Jan 8, 2025

Summary

Situation before

What's here now

Check list

  • typing, linting, docstrings (cicd will fail)
  • If adding an external service, include the relevant API keys in deployment scripts in .github/workflows (staging and prod) and GH actions
  • If changing data models in phospho-python that are used in the backend, run poetry lock in phospho-python so the backend tests CICD cache is invalidated
  • If creating an API endpoint, add it to v3 so that you can easily document it in phospho-app.github.io/docs/

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
phospho-portal 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 1:42pm

@oulianov oulianov merged commit 695b4b4 into main Jan 8, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants