Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix server-side build by allowing module usage #56

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

adamtaylor13
Copy link
Contributor

@adamtaylor13 adamtaylor13 commented Jun 12, 2023

Myself and others have run into this issue with the new (non-legacy) version of @phosphor-icons/react. I'm not really sure what the underlying difference is between this version and the older phosphor-react package, but when I made this change—suddenly my builds started working again.

Reference:
#55

@rektdeckard
Copy link
Member

This is probably OK to do, but I am worried this might have the inverse effect for non-ESM-based build tools. Seems like some tooling respect the type field, others ignore it and have a preference when module and main fields are present, and yet others have an implicit assumption that it is CJS. I have tested locally with Next and seems fine, so will build an release for now. But monitoring for issues, and will try to write update our CI to build and run test apps across a bunch of common frameworks.

@rektdeckard rektdeckard merged commit b2510b9 into phosphor-icons:master Jun 13, 2023
@rektdeckard
Copy link
Member

Thanks for the fix, @adamtaylor13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants