Update Joomla Filter package to 1.2 with PHP 7 Fixes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
photodude
added a commit
that referenced
this pull request
Feb 25, 2016
Update Joomla Filter package to 1.2 with PHP 7 Fixes
| "php": ">=5.3.10" | ||
| }, | ||
| "require-dev": { | ||
| "joomla/language": "~1.0", |
There was a problem hiding this comment.
I missed this line before merging as I was a little more focused on the input filter side. So, shouldn't the Joomla\Language\Language package be included in the required area rather than the required-dev now that use Joomla\Language\Language; is part of the output filter? If that's right wouldn't the Joomla\Language\Language package also need to be added to the CMS?
It seems if you actually try to use the Framework library output filter in the CMS you get a fatal error for the missing class ... {found while attempting to extend the JOutputFilter class in the CMS from the Framework class}
photodude
pushed a commit
that referenced
this pull request
Apr 13, 2016
Update en-GB.tpl_beez3.sys.ini
photodude
pushed a commit
that referenced
this pull request
Jun 29, 2017
* Fixed callable call in loop termination condition * Fixed non-optimal regular expression * Shortened syntax for applied operations * Don't use strlen() to check if string is empty. * Reverted preg changes. Look into those later again. * Replaced call_user_func_array() with call_user_func() * Merge unset() calls * Replaced old intval() call with modern typecasting * Optimize away substr() as index-based access * Replace some cases of substr() with strpos() * Replace some stristr() with stripos() * Replace is_null() with null === ... * Removed unnecessary ternary operators * Fix for Juri... * Revert some changes for ... PHP5.3 compatibility * Make travis happy .... * Make codesniffer happy... * DYC! * Optimize non-optimal if conditions. * codsniffer... * Inline one-time use variables * Codesniffer... * Flipped comparisons `null === ...` to Joomla Style `... === null` `null !== ...` to Joomla Style `... !== null` * Flipped comparisons `false !== ...` to Joomla Style `... !== falsel` * Fix removal of ternary operator. Forgot inversion. * More flipping of comparisons ;) * Removed another unnecessary set of ternary operators. * Codesniffer... * Type-safe comparisons on strings * More type-safe comparisons * Changes that occurred during PR discussion * Remove some unnecessary parentheses * Removed empty if-group and reversed condition * Corrections on errors during merge (Conflict resolving) * Missed one. * Remove a parenthesis * Changes according to reviewer's comment * Revert change because of failure * Changes according to reviewer's comment + a few more changes found last minute * reversed change, though according to the method's doc that value should have been an integer... * Hopefully fixed... * Hopefully fixed... * Re-apply some changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.