Skip to content

Commit

Permalink
Fix a few node tests
Browse files Browse the repository at this point in the history
  • Loading branch information
zcbenz committed Nov 7, 2023
1 parent 6910ea3 commit 3fde712
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,10 @@ jobs:
cd node
../out/Release/node_cctest
../out/Release/node test/embedding/test-embedding.js
# TODO(zcbenz): Fix the tests.
./tools/test.py --shell ../out/Release/node --flaky-tests=dontcare --skip-tests=parallel/test-crypto-no-algorithm,parallel/test-process-versions,parallel/test-snapshot-basic
# TODO(zcbenz): The parallel/test-crypto-no-algorithm test is failing,
# which was introduced by https://github.com/nodejs/node/pull/46237, I
# don't have enough experience with OpenSSL to fix it.
./tools/test.py --shell ../out/Release/node --flaky-tests=dontcare --skip-tests=parallel/test-crypto-no-algorithm
vs-toolchain:
runs-on: windows-2022
Expand Down
3 changes: 3 additions & 0 deletions scripts/bootstrap.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ const commonConfig = [
'v8_promise_internal_field_count=1',
'v8_scriptormodule_legacy_lifetime=true',
'v8_enable_maglev=false',
// TODO(zcbenz): Node.js manually updates this value in common.gypi, we should
// find out a better procedure without manual updating source code.
'v8_embedder_string="-node.0"',
// Not our job fixing the warnings.
'clang_use_chrome_plugins=false',
]
Expand Down

0 comments on commit 3fde712

Please sign in to comment.