No more need for icu_use_data_file workaround

photoionization · Dec 6, 2023 · 9da982d · 9da982d
1 parent a674790
commit 9da982d
Showing 1 changed file with 1 addition and 7 deletions.
diff --git a/scripts/bootstrap.js b/scripts/bootstrap.js
@@ -31,6 +31,7 @@ const commonConfig = [
   `target_cpu="${targetCpu}"`,
   `target_os="${targetOs}"`,
   // V8 settings required by Node.
+  'icu_use_data_file=false',
   'v8_expose_symbols=true',
   'v8_enable_sandbox=false',
   'v8_use_external_startup_data=false',
@@ -72,13 +73,6 @@ if (hostOs == 'linux') {
   // Ensure stable environment.
   commonConfig.push('use_sysroot=true')
 }
-if (targetOs == 'win' && targetCpu.endsWith('64')) {
-  // TODO(zcbenz): The icu_use_data_file should be false to make ICU work to
-  // node, but it is currently causing linking errors in win 64bit build.
-  commonConfig.push('icu_use_data_file=true')
-} else {
-  commonConfig.push('icu_use_data_file=false')
-}
 for (const arg of argv) {
   if (arg == '--ccache' && hostOs != 'win')
     commonConfig.push('cc_wrapper="ccache"')