Skip to content
This repository has been archived by the owner on Jun 26, 2018. It is now read-only.

qunit test as html #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

qunit test as html #5

wants to merge 3 commits into from

Conversation

mccalluc
Copy link
Contributor

@mccalluc mccalluc commented Nov 7, 2016

@sgratzl: I've looked, but it hasn't been apparent to me whether karma can just load html... I think not. I could imagine using selenium bindings for node to confirm that the result is what we expect, but you might have a different approach in mind?

@sgratzl
Copy link
Contributor

sgratzl commented Nov 9, 2016

this looks like an integration test, since it requires an existing build. However, the build order is: test -> build. Karma in the current configuration is for unit tests only. see for example in phovea_core

@mccalluc
Copy link
Contributor Author

mccalluc commented Nov 25, 2016

@sam: How would you like to see this work completed? My first thought is to copy-and-paste something like the ruby/selenium test runner that is being used on phovea.github.io, and in .travis.yml, change

script: npm run dist

to something like

script: 
- npm run dist
- ruby test-runner.rb

The script isn't complicated, so if you'd strongly prefer, shouldn't be hard to re-do it in node or python if you'd prefer; just let me know. (Or if integration tests belong somewhere else, that's fine too.)

@mccalluc
Copy link
Contributor Author

@sgratzl : Sorry to lose track of this. Did you have ideas about the right way to do integration tests?

@sgratzl
Copy link
Contributor

sgratzl commented Dec 15, 2016

no idea what the right way is. But what I would like to have them just as another npm command (npm run integration-test that are registered as a predist or postbuild step

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants