Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Update dependencies #67

Closed
wants to merge 6 commits into from
Closed

Update dependencies #67

wants to merge 6 commits into from

Conversation

thinkh
Copy link
Contributor

@thinkh thinkh commented Apr 16, 2018

This branch runs now on the same npm dependencies as the phovea_core.

Related PR: phovea/phovea_d3#28

@thinkh thinkh requested a review from sgratzl April 16, 2018 09:01
@thinkh
Copy link
Contributor Author

thinkh commented Apr 16, 2018

The following CI error is fixed with PR phovea/phovea_d3#28. (I haven't switched the branch dependency here.)

node_modules/phovea_d3/src/d3util.ts(57,17): error TS2394: Overload signature is not compatible with function implementation.

@sgratzl sgratzl removed their request for review March 18, 2019 07:37
@sgratzl sgratzl removed their assignment Mar 18, 2019
@thinkh
Copy link
Contributor Author

thinkh commented Dec 12, 2019

Closed because it is outdated. PR #73 has newer dependencies.

@thinkh thinkh closed this Dec 12, 2019
@thinkh thinkh deleted the update_dependencies branch December 12, 2019 16:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants