Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set full path on command string #6

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

lkm
Copy link
Contributor

@lkm lkm commented Jan 23, 2025

This action did not work with composer supplied phpcs which is the main reason you would want to override.

@g105b
Copy link
Member

g105b commented Jan 24, 2025

Thank you. Is the repo you're using this in public, so I can reference your Workflow file?

@g105b g105b merged commit 56b76ba into php-actions:master Jan 24, 2025
@lkm
Copy link
Contributor Author

lkm commented Jan 24, 2025

@g105b sorry it isn't, this is the config I used though:

jobs:
  phpcs:
    runs-on: [ubuntu-latest]
    steps:
      - uses: actions/checkout@v4

      - name: Cache Composer dependencies
        uses: actions/cache@v3
        with:
          path: /tmp/composer-cache
          key: ${{ runner.os }}-${{ hashFiles('**/composer.lock') }}

      - uses: php-actions/composer@v6
      - name: PHP Code Sniffer
        uses: lkm/phpcs@fix-vendor-file
        with:
          php_version: 8.3
          standard: phpcs.xml
          vendored_phpcs_path: vendor/bin/phpcs

All that's required is a project with composer and squizlabs/php_codesniffer installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants