Skip to content

Fix vendored_phpmd_path #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Fix vendored_phpmd_path #2

merged 3 commits into from
Jul 10, 2024

Conversation

shanept
Copy link
Contributor

@shanept shanept commented Jul 9, 2024

Hi Greg,

This is the pull request that fixes #1 .

It is, for all intents and purposes an identical equivalent to my pull request for phpunit, with one exception.

There are 3 commits. In the second commit, I have changed the debug logging from the style you have been using (piping output to output.log) to the github actions debug output method. That means this output now shows up when a job is run in debug mode.

For reference, see here: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-a-debug-message

My preference would be for your error messages to move towards this method. If you aren't interested, let me know and I will remove the commit so you can merge.

Cheers

@g105b
Copy link
Member

g105b commented Jul 10, 2024

Hi @shanept,

Thank you for this. At the time of writing these actions, the output.log was the only way to achieve this (I was an early adopter of Github Actions, and there were plenty of missing features at the time!)

This is really useful, as debugging the output.log has always been a real chore. I'll try and find some time to implement this for the other repos.

Thanks again!

@g105b g105b merged commit f80ddad into php-actions:master Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Issue with vendored_phpmd_path
2 participants