Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change! #30

Open
hosni opened this issue Dec 9, 2024 · 3 comments
Open

Breaking change! #30

hosni opened this issue Dec 9, 2024 · 3 comments

Comments

@hosni
Copy link

hosni commented Dec 9, 2024

Hello, in the #21 there is a breaking change!
Many projects use the standalone version of PHPstan without using Composer.

But with changes that were made in #21 the default value of version is changed to composer and it's a breaking change!
Because many CIs relied on this and it was broken now!
I think it should be published under a new version!
Or, using a fallback strategy to fix this.

image

@hosni hosni changed the title Breaking change made! Breaking change! Dec 9, 2024
@g105b
Copy link
Member

g105b commented Dec 12, 2024

Hi @hosni thank you for reporting this.

You are completely correct! I appologise for this oversight.

What course of action do you think it the most appropriate? Should I recall the changes to the latest rolling release, and make a new stable release version, or do you think it would cause more issues in altering the existing release?

@hosni
Copy link
Author

hosni commented Dec 15, 2024

Hi @g105b thank for your great job here.

I think it's better to just change the default value of the version input to it's previous value (latest), and keep the changes still remain.
There is no need to revert whole PR, just changing the default value is enough.

And in the next major version, change it back again to composer.

Anything missed?

@g105b
Copy link
Member

g105b commented Dec 19, 2024

I think that's the best approach. I will make this change today, and mark the change to be made for the next version. Thanks for you insight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants