-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking change! #30
Comments
Hi @hosni thank you for reporting this. You are completely correct! I appologise for this oversight. What course of action do you think it the most appropriate? Should I recall the changes to the latest rolling release, and make a new stable release version, or do you think it would cause more issues in altering the existing release? |
Hi @g105b thank for your great job here. I think it's better to just change the default value of the And in the next major version, change it back again to Anything missed? |
I think that's the best approach. I will make this change today, and mark the change to be made for the next version. Thanks for you insight. |
Hello, in the #21 there is a breaking change!
Many projects use the standalone version of PHPstan without using Composer.
But with changes that were made in #21 the default value of
version
is changed tocomposer
and it's a breaking change!Because many CIs relied on this and it was broken now!
I think it should be published under a new version!
Or, using a fallback strategy to fix this.
The text was updated successfully, but these errors were encountered: