Add option to point to a vendored phpunit executable #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @blackwolf12333 - testing locally is a real pain to be honest. I've set up https://github.com/php-actions/example-phpunit for this purpose, so I'll give this PR a test within that repo as soon as I can, and we can get this useful change merged. |
|
Thanks @g105b, I actually tried testing this in our private repo but couldn't get it to work so I'd be great if you could! Cleaned up the commits from my own testing. |
blackwolf12333
force-pushed
the
master
branch
from
f5db1c8 to
16b9619
Compare
|
Tested here: https://github.com/php-actions/example-phpunit/actions/runs/3430440488/jobs/5717404543 Works a treat 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not really sure how to test local changes to a github action so this change isn't tested in any way. But hopefully this provides a good starting point at least.
Improves the situation described in #43.