Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent the evening trying to integrate the 2.0 stuff into my private project, and wound up having to fix several little issues that didn't come up before:
Model::find
ConstArrayType
, now it only decides an array if trinaryYES
and anything else (NO
orMAYBE
) is interpreted to be a single.bccomp
, and added PHPStan ignore statement for the weird out-of-range int checking trick.I still have at least one issue around
bccomp
to sort out, but otherwise everything was pretty simple and took only a few hours to port over (with much of that time consumed by the fixes I had to do in this library).