Skip to content

Conversation

shmax
Copy link
Contributor

@shmax shmax commented Sep 25, 2023

I spent the evening trying to integrate the 2.0 stuff into my private project, and wound up having to fix several little issues that didn't come up before:

  • fixed several typos
  • handle the case that client doesn't supply a logger
  • fixed docs for Model::find
  • greatly simplified the dynamic return extension stuff (before, it only detected array type if the one-and-only argument was a ConstArrayType, now it only decides an array if trinary YES and anything else (NO or MAYBE ) is interpreted to be a single.
  • removed the dependency on bccomp, and added PHPStan ignore statement for the weird out-of-range int checking trick.

I still have at least one issue around bccomp to sort out, but otherwise everything was pretty simple and took only a few hours to port over (with much of that time consumed by the fixes I had to do in this library).

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #101 (8df044d) into master (43b8d09) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #101   +/-   ##
=========================================
  Coverage     98.81%   98.81%           
- Complexity      953      955    +2     
=========================================
  Files            34       34           
  Lines          2362     2365    +3     
=========================================
+ Hits           2334     2337    +3     
  Misses           28       28           
Files Changed Coverage Δ
lib/Column.php 100.00% <100.00%> (ø)
lib/Config.php 100.00% <100.00%> (ø)
lib/Connection.php 97.07% <100.00%> (ø)
lib/Model.php 99.76% <100.00%> (ø)
lib/Relation.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shmax shmax merged commit e847c2e into master Sep 25, 2023
@shmax shmax deleted the various-fixes branch September 25, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant