throw RecordNotFound on empty find #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 936 936
===========================================
Files 34 34
Lines 2345 2349 +4
===========================================
+ Hits 2345 2349 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Confirmed that this was a bug. It seems to predate all this recent 2.0 work (I rolled back), so it must be something that broke in the last few years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understand correctly, Rails throws a
RecordNotFoundexception when you pass an empty array tofind, and we don't seem to be doing that. I still have a little more research to do, but opening a PR in the meantime.Also, there are a few points in the code where we retrieve static members from classes via reflection that may or may not exist, and this was throwing warnings.