Skip to content

Conversation

phpfui
Copy link
Contributor

@phpfui phpfui commented Jun 25, 2025

I simply ran vendor\bin\php-cs-fixer fix

This automatically will convert to PHP 8.4 to fix this error (and all the others):

Deprecated: ActiveRecord\Table::insert(): Implicitly marking parameter $sequence_name as nullable is deprecated, the explicit nullable type must be used instead in vendor\php-patterns\activerecord\lib\Table.php on line 411

Please merge. Thanks

@shmax
Copy link
Contributor

shmax commented Jun 25, 2025

Nice, but we'll have to fix the CI. Can you do a few things?

  1. update the ubuntu-20.04 version in the workflow files to ubuntu-22.04
  2. add PHP 8.4 to the various matrices in the workflow files

@phpfui
Copy link
Contributor Author

phpfui commented Jun 25, 2025

OK, but later today.

@shmax
Copy link
Contributor

shmax commented Jun 25, 2025

Better! You got the tests to pass, that's awesome. Any chance you can sort out the phpstan and php-cs-fixer issues? If not, no big deal, I can figure them out later.

@phpfui
Copy link
Contributor Author

phpfui commented Jun 25, 2025

Probably best if you do it, as you know the code better. Also you should upgrade to PHPStan V2.

Thanks

@shmax
Copy link
Contributor

shmax commented Jun 25, 2025

I put the style workflow back on PHP 8.3 (php-cs-fixer doesn't support 8.4 yet), and fixed the PHPStan issues (I don't have the energy to try out v2 right now), and everything appears to be green.

@shmax shmax merged commit 4c4987c into php-activerecord:master Jun 25, 2025
14 checks passed
@shmax
Copy link
Contributor

shmax commented Jun 25, 2025

Thanks very much! Keep 'em coming.

@phpfui phpfui deleted the PHP84 branch June 26, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants