more dynamic phpstan extensions #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I get static checking for
Model::find_all...andModel::find_by...magic methods sort of working, in that they return array or singular results, respectively:There's a lot more to do, namely exception reporting, arguments, and so on, but this stuff isn't really documented very well on the phpstan side of things, and I don't really know what I'm doing, so I guess we'll see how much energy I have.
edit: I think I have the arguments static checking working as well as is possible, meaning I validate the number of arguments, but not the exact type (as that would require knowledge of the database schema).