Reorganize Model::$belongs_to, Model::$has_one #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganizing
Model::$belongs_to
andModel::$has_one
from this:to this:
This makes static checking on the options possible, and easier to read IMO.
TODO: a lot of the tests rely on static members like
Model::$belongs_to
,Model::$has_one
, and so on. Some of the tests would try to cache and restore the state of these, others would append, still others would reset, which can lead to chaos. I think what we need to do is figure out how to do some kind ofbefore_test
sort of thing where we always blank those out, or maybe do some kind of mocking, or something.