cycle over all connections #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
============================================
+ Coverage 96.91% 97.40% +0.48%
- Complexity 968 975 +7
============================================
Files 33 34 +1
Lines 2367 2386 +19
============================================
+ Hits 2294 2324 +30
+ Misses 73 62 -11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
About what I was afraid of... ..F....................E.................E..................... 63 / 789 ( 7%)
.................E............EEFE.E...F...........FF.......... 126 / 789 ( 15%)
......EFEE.EE....EEEEE..E.EEE.E.EEEE..EEEE.EE...EEEEEEEE.EEFEE. [18](https://github.com/php-activerecord/activerecord/actions/runs/6231683665/job/16913582298?pr=88#step:10:19)9 / 789 ( [23](https://github.com/php-activerecord/activerecord/actions/runs/6231683665/job/16913582298?pr=88#step:10:24)%)
...........EEEEE...EEEE..E...EE...SFFE..SEE....E..............E [25](https://github.com/php-activerecord/activerecord/actions/runs/6231683665/job/16913582298?pr=88#step:10:26)2 / 789 ( 31%)
........................EE.................................F... 315 / 789 ( 39%)
.......EE................EEE...E..........EEEEEEEE............. 378 / 789 ( 47%)
............................................................... 441 / 789 ( 55%)
........................EE..EE.....E.F.........E.......EE.EE... 504 / 789 ( 63%)
..........................E............E........F.............. 567 / 789 ( 71%)
....S.....S....................E............................... 630 / 789 ( 79%)
.............................................EEEEEEEEEEEEEEEEEE 693 / 789 ( 87%)
EEEEEEEEEEEEEEEEEEEFFEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE.EEEE. 756 / 789 ( 95%)
EEE.................F.........FFF 789 / 789 (100%) |
|
Well, the good news is that I managed to speed up the tests by a factor of 5, but the bad news is that a lot of the tests that pass on local are failing in the CI. Sigh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the CI now iterates over each of the supported connection types (
mysql,sqlite, andpgsql) and runs the entire test suite.The adapter test cases will skip if they don't match with the connection type (so that we don't needlessly run them 3 times).
Had to fix tons of little problems to get this all working.
I also modified
DatabaseTestCaseso that it now only tears down the test database at when beginning each class, as opposed to each test. This speeds things up quite a bit, but opens us up to little issues (eg. adding a record in test A can throw off test B that doesn't expect it to exist), so I may have to undo that at some point if it becomes a major annoyance.