Skip to content

Conversation

shmax
Copy link
Contributor

@shmax shmax commented Sep 23, 2023

Some more scattered attempts to increase coverage:

  • replace unused throws with assert statements
  • create Connection::data_source_name to exercise unix socket stuff in tests
  • test for create_association

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #92 (29a1ca3) into master (23e4070) will increase coverage by 0.70%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
+ Coverage     97.40%   98.10%   +0.70%     
+ Complexity      975      970       -5     
============================================
  Files            34       34              
  Lines          2386     2378       -8     
============================================
+ Hits           2324     2333       +9     
+ Misses           62       45      -17     
Files Changed Coverage Δ
lib/Connection.php 94.88% <100.00%> (+2.18%) ⬆️
lib/Model.php 99.54% <100.00%> (+<0.01%) ⬆️
lib/Relationship/HasMany.php 100.00% <100.00%> (+17.64%) ⬆️
lib/cache/Memcache.php 100.00% <100.00%> (+6.25%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shmax shmax merged commit cc4018c into master Sep 23, 2023
@shmax shmax deleted the increase-coverage branch September 23, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant