Skip to content

Conversation

shmax
Copy link
Contributor

@shmax shmax commented Sep 23, 2023

Removing the concept of passing conditions to Model:

  • moved delete_all to Relation
  • changed Table::delete to work more similarly to Table::find.

Since it now chains off of Where like anything else, I was able to remove all the tests that were exercising different args delete_all.

@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

Merging #94 (2aba4ac) into master (904ca1f) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #94      +/-   ##
============================================
+ Coverage     98.31%   98.35%   +0.04%     
+ Complexity      964      960       -4     
============================================
  Files            34       34              
  Lines          2372     2369       -3     
============================================
- Hits           2332     2330       -2     
+ Misses           40       39       -1     
Files Changed Coverage Δ
lib/SQLBuilder.php 100.00% <ø> (ø)
lib/Model.php 99.76% <100.00%> (+0.22%) ⬆️
lib/Relation.php 100.00% <100.00%> (ø)
lib/Table.php 99.06% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shmax shmax merged commit 5f95ce4 into master Sep 23, 2023
@shmax shmax deleted the update-delete-all branch September 23, 2023 23:22
@shmax shmax mentioned this pull request Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant