Merge pull request #6 from boekkooi/expire-cleanup

Remove the cache file when a expire item was required
php-cache · Jan 24, 2016 · 97266e6 · 97266e6
2 parents 199382d + 4b66509
commit 97266e6
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/FilesystemCachePool.php b/src/FilesystemCachePool.php
@@ -46,6 +46,8 @@ protected function fetchObjectFromCache($key)
 
  $data = unserialize($this->filesystem->read($file));
  if ($data[0] !== null && time() > $data[0]) {
+ $this->clearOneObjectFromCache($key);
+
  return [false, null];
  }
 

diff --git a/tests/FilesystemCachePoolTest.php b/tests/FilesystemCachePoolTest.php
@@ -27,4 +27,21 @@ public function testInvalidKey()
 
  $pool->getItem('test%string')->get();
  }
+
+ public function testCleanupOnExpire()
+ {
+ $pool = $this->createCachePool();
+
+ $item = $pool->getItem('test_ttl_null');
+ $item->set('data');
+ $item->expiresAt(new \DateTime('now'));
+ $pool->save($item);
+ $this->assertTrue($this->getFilesystem()->has('cache/test_ttl_null'));
+
+ sleep(1);
+
+ $item = $pool->getItem('test_ttl_null');
+ $this->assertFalse($item->isHit());
+ $this->assertFalse($this->getFilesystem()->has('cache/test_ttl_null'));
+ }
 }