Skip to content

Conversation

@basakest
Copy link
Contributor

@basakest basakest commented Aug 1, 2021

No description provided.

Copy link
Member

@leeqvip leeqvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix checks failed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1096128839

  • 0 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 89.362%

Files with Coverage Reduction New Missed Lines %
src/Model/Table/CasbinRuleTable.php 2 0%
Totals Coverage Status
Change from base Build 1048407662: -0.8%
Covered Lines: 126
Relevant Lines: 141

💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 4, 2021

Pull Request Test Coverage Report for Build 1096588452

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 89.362%

Files with Coverage Reduction New Missed Lines %
src/Model/Table/CasbinRuleTable.php 2 0.0%
Totals Coverage Status
Change from base Build 1048407662: -0.8%
Covered Lines: 126
Relevant Lines: 141

💛 - Coveralls

run: |
cd vendor/cakephp/app
composer install --prefer-dist --no-progress --no-suggest
cp ../../../tests/app.php ./config/app.php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not recommended to modify the default configuration in this way, you can modify it at the code level .

"license": "Apache-2.0",
"require": {
"cakephp/cakephp": "3.*",
"php": ">=7.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format .

feat: support updatePolicies method, upgrade dependencies

feat: support updatePolicies method, upgrade dependencies

feat: support updatePolicies method, upgrade dependencies
@leeqvip leeqvip merged commit 9590645 into php-casbin:master Aug 23, 2021
@leeqvip
Copy link
Member

leeqvip commented Aug 23, 2021

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants