Skip to content

Include userId in log messages by using MDC #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Jul 24, 2019 · 2 comments
Closed

Include userId in log messages by using MDC #1102

php-coder opened this issue Jul 24, 2019 · 2 comments
Assignees
@mukeshk
Labels
area/logging estimation/45m Estimated time: 45 minutes kind/task Task that is part of some feature
Milestone
0.4.1

Comments

@php-coder
Copy link
Owner

php-coder commented Jul 24, 2019 •
edited
Loading

Acceptance criteria:

  • every log message contains userId

How to achieve that:

  • add Servlet Filter that puts userId into MDC
  • modify log pattern to include a userId from MDC

Hint:

Part of #388
@php-coder php-coder added the kind/task Task that is part of some feature label Jul 24, 2019
@php-coder php-coder added this to the 0.4.1 milestone Jul 24, 2019
@mukeshk
Copy link
Contributor

mukeshk commented Jul 25, 2019

How about an anonymous user?

@php-coder
Copy link
Owner Author

In this case, log message will contain an empty userId. The same for Spring Boot logs or repeated tasks that we run for maintenance.

Another option is to use 0 UID as it never exists. Let's use the first approach and will change it if necessary.

mukeshk added a commit to mukeshk/mystamps that referenced this issue Jul 27, 2019
@mukeshk
task(/mdc/log/userId) : Include userId in log messages by using MDC
caa8b10 
Part of php-coder#388
Fix php-coder#1102
mukeshk added a commit to mukeshk/mystamps that referenced this issue Jul 27, 2019
@mukeshk
task(area/logging) : Include userId in log messages by using MDC
b5ec709 
Part of php-coder#388
Fix php-coder#1102
@mukeshk mukeshk mentioned this issue Jul 27, 2019
Merged
mukeshk added a commit to mukeshk/mystamps that referenced this issue Jul 28, 2019
@mukeshk
task(area/logging) : Include userId in log messages by using MDC
5a34aff 
Part of php-coder#388
Fix php-coder#1102
mukeshk added a commit to mukeshk/mystamps that referenced this issue Jul 28, 2019
@mukeshk
task(area/logging) : Include userId in log messages by using MDC
9408307 
Part of php-coder#388
Fix php-coder#1102
mukeshk added a commit to mukeshk/mystamps that referenced this issue Jul 28, 2019
@mukeshk
task(area/logging) : Include userId in log messages by using MDC
13a11b7 
Part of php-coder#388
Fix php-coder#1102
mukeshk added a commit to mukeshk/mystamps that referenced this issue Jul 28, 2019
@mukeshk
task(area/logging) : Include userId in log messages by using MDC
4ecf0a5 
Part of php-coder#388
Fix php-coder#1102
mukeshk added a commit to mukeshk/mystamps that referenced this issue Jul 29, 2019
@mukeshk
task(area/logging) : Include userId in log messages by using MDC
646fd3a 
Related links:
- http://logback.qos.ch/manual/mdc.html
- http://docs.spring.io/spring-boot/docs/1.5.x/reference/html/boot-features-logging.html

Part of php-coder#388
Fix php-coder#1102
mukeshk added a commit to mukeshk/mystamps that referenced this issue Jul 29, 2019
@mukeshk
task(area/logging) : Include userId in log messages by using MDC
d93b033 
Related links:
- http://logback.qos.ch/manual/mdc.html
- http://docs.spring.io/spring-boot/docs/1.5.x/reference/html/boot-features-logging.html

Part of php-coder#388
Fix php-coder#1102
mukeshk added a commit to mukeshk/mystamps that referenced this issue Jul 29, 2019
@mukeshk
task(area/logging) : Include userId in log messages by using MDC
0630ebc 
Related links:
- http://logback.qos.ch/manual/mdc.html
- http://docs.spring.io/spring-boot/docs/1.5.x/reference/html/boot-features-logging.html

Part of php-coder#388
Fix php-coder#1102
mukeshk added a commit to mukeshk/mystamps that referenced this issue Jul 29, 2019
@mukeshk
task: include userId in the log messages by using MDC.
bf42149 
Related links:
- http://logback.qos.ch/manual/mdc.html
- http://docs.spring.io/spring-boot/docs/1.5.x/reference/html/boot-features-logging.html

Part of php-coder#388
Fix php-coder#1102
mukeshk added a commit to mukeshk/mystamps that referenced this issue Jul 29, 2019
@mukeshk
task: include userId in the log messages by using MDC.
94e87d5 
Related links:
- http://logback.qos.ch/manual/mdc.html
- http://docs.spring.io/spring-boot/docs/1.5.x/reference/html/boot-features-logging.html

Part of php-coder#388
Fix php-coder#1102
@php-coder php-coder mentioned this issue Jul 29, 2019
Open
@php-coder php-coder added the estimation/45m Estimated time: 45 minutes label Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mukeshk mukeshk

Labels
area/logging estimation/45m Estimated time: 45 minutes kind/task Task that is part of some feature
Projects
None yet
Milestone
0.4.1
Development

No branches or pull requests
2 participants
@php-coder @mukeshk