Skip to content

Introduce a dedicated config for DAO classes #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
0pdd opened this issue Nov 8, 2019 · 0 comments
Closed

Introduce a dedicated config for DAO classes #1150

0pdd opened this issue Nov 8, 2019 · 0 comments
Assignees
@php-coder
Labels
area/unit tests dependency/spring Task is related to Spring Framework refactoring techdebt
Milestone
0.4.2

Comments

@0pdd
Copy link

0pdd commented Nov 8, 2019 •
edited by php-coder
Loading

The puzzle 1143-f4576026 from #1143 has to be resolved:

mystamps/src/test/java/ru/mystamps/web/feature/category/JdbcCategoryDaoTest.java

Line 35 in 7de0591

// @todo #1143 Introduce a dedicated config for DAO classes

The puzzle was created by Slava Semushin on 08-Nov-19.
@0pdd 0pdd added the techdebt label Nov 8, 2019
0pdd referenced this issue Nov 8, 2019
@php-coder
test(JdbcCategoryDaoTest): add tests for getStatisticsOf() method.
7de0591 
Prerequisite for #1143
@0pdd 0pdd mentioned this issue Nov 8, 2019
Closed
@php-coder php-coder added area/unit tests refactoring dependency/spring Task is related to Spring Framework labels Nov 8, 2019
@php-coder php-coder added this to the 0.5 milestone Nov 8, 2019
@php-coder php-coder self-assigned this Dec 12, 2019
@php-coder php-coder modified the milestones: 0.5, 0.4.3, 0.4.2 Dec 12, 2019
php-coder added a commit that referenced this issue Dec 12, 2019
@php-coder
refactor: move a country dao class into shared dao configutation.
0b32030 
Now JdbcCountryDaoTest doesn't depend on a service class and we can stop @ignore this test. This
removes a hack that has been added in e004fa3 commit (#1163).

Part of #1150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
area/unit tests dependency/spring Task is related to Spring Framework refactoring techdebt
Projects
None yet
Milestone
0.4.2
Development

No branches or pull requests
2 participants
@php-coder @0pdd