Skip to content

series_sales.date: change type to DATE #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
php-coder opened this issue Aug 28, 2016 · 0 comments
Closed

series_sales.date: change type to DATE #471

php-coder opened this issue Aug 28, 2016 · 0 comments
Assignees
@cssru
Labels
refactoring
Milestone
0.4

Comments

@php-coder
Copy link
Owner

I don't see a reason of why series_sales.date should have DATETIME type. We don't need the time here, so I assume that we can narrow type to DATE. Of course we should check that existing data will be migrated properly.

Related to #198
@php-coder php-coder added this to the next milestone Aug 28, 2016
@cssru cssru mentioned this issue Oct 10, 2016
Closed
@php-coder php-coder modified the milestones: 0.4, next Oct 11, 2016
bodom91 pushed a commit to bodom91/mystamps that referenced this issue Aug 2, 2017
@cssru @bodom91
Change type of series_sales.date to DATE.
7536067 
Fix php-coder#471

No functional changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cssru cssru

Labels
refactoring
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@php-coder @cssru